Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix price/currency checks #7

Open
coyotte508 opened this issue Apr 19, 2023 · 2 comments · May be fixed by #1637
Open

🐛 Fix price/currency checks #7

coyotte508 opened this issue Apr 19, 2023 · 2 comments · May be fixed by #1637
Labels
3 - Low Donator:NPR

Comments

@coyotte508
Copy link
Collaborator

For example we can't go below 1 cent for EUR, or 1 satoshi for BTC
@Tirodem Tirodem removed the not-mvp label Jul 11, 2023
@Tirodem
Copy link
Contributor

Tirodem commented Jan 19, 2024

We have a current something-something in this perimeter :
image
That shouldn't trigger at 0.01EUR or any fiat device.
Otherwise, saying that if it's < 1SAT or 0.01 of a fiat device becoming free article is something OK for me.
BTW, we have this to fix to complexe the price / currency check : #338

@Tirodem Tirodem changed the title Add price/currency checks 🐛 Fix price/currency checks Jan 19, 2024
@ithiame
Copy link
Contributor

ithiame commented Dec 10, 2024 •
edited
Loading

Otherwise, saying that if it's < 1SAT or 0.01 of a fiat device becoming free article is something OK for me.

Let's apply this and trigger the warning only if it's < CURRENCY_UNIT[currency]

ithiame added a commit that referenced this issue Dec 10, 2024
@ithiame
🐛 Fix price/currency checks #7
7aafd11
@ithiame ithiame linked a pull request Dec 10, 2024 that will close this issue
🐛 Fix price/currency checks #7 #1637
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - Low Donator:NPR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix price/currency checks #7 B2Bitcoin/beBOP
3 participants
@coyotte508 @Tirodem @ithiame