Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aes.h missing aes_decrypt_cbc? #8

Open
Kargor opened this issue Aug 5, 2016 · 0 comments
Open

Aes.h missing aes_decrypt_cbc? #8

Kargor opened this issue Aug 5, 2016 · 0 comments

Comments

@Kargor
Copy link

Kargor commented Aug 5, 2016

Maybe I'm just dumb as the test program probably compiles for other people, but it complains about aes_decrypt_cbc() being undeclared. And I'm not seeing it in the aes.h...

Also, I think the base64_test.c isn't working -- it needs to zero the "buf" before doing the encode as well, or the result won't be 0-terminated which makes the strcmp() fail.

As a side note, strcmp()/strlen takes "const char_", while the BYTE_ is unsigned. This probably doesn't affect a C-compilation, though. On the other hand, casts won't affect the C-compilation either, but will fix C++ compilations :-)

And while I'm at it -- the "BYTE ch" at the top of base64_decode() isn't used, which produces a warning to that effect (unless warnings are disabled, of course).

Not sure whether this works, but here's a diff with the suggested changes:
Diff.txt
Might not be the most useful thing, though. I don't know whether the result of "svn diff" can be used for anything other than looking at it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant