-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid protocol-property list - CFURLRequestRef #1362
Comments
ADAL 4.0.0 should fix this issue, as it gets rid of custom url protocol altogether. Will take a closer look at fixing this in 2.7.8 as well. |
@oldalton pod install error new version
|
ADAL 4.0.0 hasn't been published to CocoaPods yet, as it's a pre-release version. It will be published to CocoaPods mid next week, unless there're new issues reported with it. For testing in the meantime, you can point CocoaPods to 4.0.0 tag in this repository: ADAL 4.0.0 release |
@oldalton still waiting for release!!!! |
Just pushed it out. Sorry for a delay, we were trying to verify one customer report that it's not impacting latest release. Thanks. |
Add the initial version of the Mac Microsoft Authentication Helper using ADAL 2.5.1 via CocoaPods. The pods are statically linked so only a single executable "Microsoft.Authentication.Helper" is required to be distributed with GCM. ADAL 2.5.1 was chosen because later ADAL versions include a bug where errors were being written to standard error: AzureAD/azure-activedirectory-library-for-objc#1362
Add the initial version of the Mac Microsoft Authentication Helper using ADAL 2.5.1 via CocoaPods. The pods are statically linked so only a single executable "Microsoft.Authentication.Helper" is required to be distributed with GCM. ADAL 2.5.1 was chosen because later ADAL versions include a bug where errors were being written to standard error: AzureAD/azure-activedirectory-library-for-objc#1362
Mac command line tools run into this potentially blocking issue, starting sometime between ADAL 2.5.1 & 2.7.4 releases. Calling acquireToken APIs leads to the following message piped to the stderr, that cannot be controlled by the caller. Some such tools cannot function correctly if any stderr output is seen by the caller, and such an error will definitely be confusing to the users as well.
Based on discussion in #1026, this seems to be caused due to carrying the whole request context in ADURLProtocol:
For GUI apps, this error gets piped to the system Console.app, which is harmless, but not ideal either. For command line tools, this can be a blocking issue depending on their usage.
@oldalton
The text was updated successfully, but these errors were encountered: