Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid protocol-property list - CFURLRequestRef #1362

Open
hi-kumar opened this issue Dec 18, 2018 · 5 comments
Open

Invalid protocol-property list - CFURLRequestRef #1362

hi-kumar opened this issue Dec 18, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@hi-kumar
Copy link

Mac command line tools run into this potentially blocking issue, starting sometime between ADAL 2.5.1 & 2.7.4 releases. Calling acquireToken APIs leads to the following message piped to the stderr, that cannot be controlled by the caller. Some such tools cannot function correctly if any stderr output is seen by the caller, and such an error will definitely be confusing to the users as well.

ERROR: createEncodedCachedResponseAndRequestForXPCTransmission - Invalid protocol-property list - CFURLRequestRef. protoProps=<CFBasicHash 0x7fde2290c7c0 [0x7fffa9a228f0]>{type = mutable dict, count = 1,
entries =>
0 : <CFString 0x10c2634e8 [0x7fffa9a228f0]>{contents = "context"} = <ADWebAuthRequest: 0x7fde229085e0>

Based on discussion in #1026, this seems to be caused due to carrying the whole request context in ADURLProtocol:

[NSURLProtocol setProperty:context forKey:@"context" inRequest:request];

For GUI apps, this error gets piped to the system Console.app, which is harmless, but not ideal either. For command line tools, this can be a blocking issue depending on their usage.

@oldalton

@oldalton oldalton added the bug label Dec 23, 2018
@oldalton oldalton added this to the 2.7.8 milestone Dec 23, 2018
@oldalton
Copy link
Member

ADAL 4.0.0 should fix this issue, as it gets rid of custom url protocol altogether. Will take a closer look at fixing this in 2.7.8 as well.

@oldalton oldalton self-assigned this Dec 23, 2018
@bhumin3i
Copy link

bhumin3i commented Jan 17, 2019

@oldalton pod install error new version

[!] CocoaPods could not find compatible versions for pod "ADAL":
In Podfile:
ADAL (= 4.0.0)

None of your spec sources contain a spec satisfying the dependency: ADAL (= 4.0.0).

pod 'ADAL', '2.7.7' is works

@oldalton
Copy link
Member

oldalton commented Jan 17, 2019

ADAL 4.0.0 hasn't been published to CocoaPods yet, as it's a pre-release version. It will be published to CocoaPods mid next week, unless there're new issues reported with it.

For testing in the meantime, you can point CocoaPods to 4.0.0 tag in this repository: ADAL 4.0.0 release

@bhumin3i
Copy link

bhumin3i commented Feb 6, 2019

@oldalton still waiting for release!!!!

@oldalton
Copy link
Member

oldalton commented Feb 6, 2019

Just pushed it out. Sorry for a delay, we were trying to verify one customer report that it's not impacting latest release. Thanks.

caixtong pushed a commit to caixtong/credent-manager that referenced this issue Jun 19, 2022
Add the initial version of the Mac Microsoft Authentication Helper
using ADAL 2.5.1 via CocoaPods. The pods are statically linked so
only a single executable "Microsoft.Authentication.Helper" is
required to be distributed with GCM.

ADAL 2.5.1 was chosen because later ADAL versions include a bug
where errors were being written to standard error:

AzureAD/azure-activedirectory-library-for-objc#1362
imgbot bot pushed a commit to Jeverett3000/Git-Credential-Manager-Core that referenced this issue Nov 2, 2022
Add the initial version of the Mac Microsoft Authentication Helper
using ADAL 2.5.1 via CocoaPods. The pods are statically linked so
only a single executable "Microsoft.Authentication.Helper" is
required to be distributed with GCM.

ADAL 2.5.1 was chosen because later ADAL versions include a bug
where errors were being written to standard error:

AzureAD/azure-activedirectory-library-for-objc#1362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants