Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max variable linter: not taking into account recently increased limit #15457

Closed
jeskew opened this issue Nov 1, 2024 · 0 comments · Fixed by #15464
Closed

Max variable linter: not taking into account recently increased limit #15457

jeskew opened this issue Nov 1, 2024 · 0 comments · Fixed by #15464
Assignees
Labels
devdiv Related to Bicep tooling efforts in DevDiv story: linter rules
Milestone

Comments

@jeskew
Copy link
Contributor

jeskew commented Nov 1, 2024

The max-variables linter issues an Error-level diagnostic when a template has more than 256 variables. According to the docs page on ARM template limits, the limit is now 512. (I confirmed in the deployment engine codebase that 512 is correct.) This could lead to false positives.

Moved to #15461:
The linter is also not counting variables imported directly or as part of the closure of another imported symbol. This could lead to false negatives.

@github-project-automation github-project-automation bot moved this to Todo in Bicep Nov 1, 2024
@StephenWeatherford StephenWeatherford self-assigned this Nov 1, 2024
@StephenWeatherford StephenWeatherford added devdiv Related to Bicep tooling efforts in DevDiv story: linter rules and removed Needs: Triage 🔍 labels Nov 1, 2024
@StephenWeatherford StephenWeatherford added this to the v0.32 milestone Nov 1, 2024
@StephenWeatherford StephenWeatherford changed the title Max variable linter inaccuracies Max variable linter: not taking into account recently increased limit Nov 1, 2024
@StephenWeatherford StephenWeatherford moved this from Todo to In Progress in Bicep Nov 1, 2024
@StephenWeatherford StephenWeatherford moved this from In Progress to In Review in Bicep Nov 1, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Bicep Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devdiv Related to Bicep tooling efforts in DevDiv story: linter rules
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants