Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates needed for authentication changes with deployment inside vscode #15450

Open
StephenWeatherford opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@StephenWeatherford
Copy link
Contributor

StephenWeatherford commented Oct 31, 2024

These changes will probably ship at end of November. Please see #15403 for the necessary doc changes that I found.

@github-project-automation github-project-automation bot moved this to Todo in Bicep Oct 31, 2024
@StephenWeatherford StephenWeatherford added this to the v0.32 milestone Oct 31, 2024
@stephaniezyen stephaniezyen added documentation Improvements or additions to documentation and removed Needs: Triage 🔍 labels Nov 6, 2024
StephenWeatherford added a commit that referenced this issue Nov 15, 2024
Fixes [14101](#14101)

NOTE: I plan on not merging this until the current release ships, so we
have some time to dogfood internally before the December release.

Fixes #14101 
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/15403)

- [x] Check if documentation needs to change
- [x]
https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/deploy-vscode
    - entered  #15450
  - [x] Clouds
- [x] Wait for multiple-account issue to be fixed (see below)?
  - Entered #15453
- [x] Check #8714 
- [ ] Add to readme notes
  - UI changes below
  - Multiple F1 commands if Azure Account extension still installed
  - Multiple accounts issue if still a problem

Overview of UI changes (images from
https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/deploy-vscode)

> <img width="732" alt="image"
src="https://github.com/user-attachments/assets/22dd96cb-2300-4047-a0be-dbb189b99f19">
NEW: You never see this menu now. Instead, if you aren't logged in,
you'll see something like this:
<img width="374" alt="image"
src="https://github.com/user-attachments/assets/92b35128-67e3-4e8e-b472-7aea0c1d52b7">

> <img width="782" alt="image"
src="https://github.com/user-attachments/assets/fef8c2d9-1060-4c1b-9fa4-1ed26c23db65">
NEW: Bicep no longer uses the Azure Account extension (it's being
deprecated). Instead, it uses new built-in vscode functionality that is
integrated with vscode's UI, e.g.:
<img width="655" alt="image"
src="https://github.com/user-attachments/assets/579b96b1-ee35-4502-8403-2196081a6d77">
and also integrates with other extensions like the Azure Resources
extension.

The statement that deployment doesn't use values from the
bicepconfig.json is correct. Instead, if you need to sign in to a custom
cloud, use this vscode setting before signing in:
<img width="1254" alt="image"
src="https://github.com/user-attachments/assets/cecb5371-767c-4d1c-8fdf-4fdd0154d04a">

Note: multiple signed-in accounts isn't currently supported (you may
need to sign out of one first using the vscode UI above), although
hopefully that will be fixed soon, perhaps even before this feature
change ships.

---------

Co-authored-by: Stephen Weatherford <Stephen.Weatherford.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Todo
Development

No branches or pull requests

3 participants