Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming generated by asoctl #4349

Open
theunrepentantgeek opened this issue Oct 16, 2024 · 0 comments
Open

Improve naming generated by asoctl #4349

theunrepentantgeek opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
cx-request Requests from customers received through non-GitHub channels
Milestone

Comments

@theunrepentantgeek
Copy link
Member

theunrepentantgeek commented Oct 16, 2024

Describe the current behavior

When importing resources using asoctl, it synthesizes resource names based on the hierarchy of ownership in order to generate unique names for every resource.

This means that we generate different names based on which root is specified for import - importing an entire resource group will give different resource names compared to importing something more specific.

Describe the improvement

Ideally, we'd generate the same names for resources regardless of the root used for the import. Even better, if we only synthesize unique names where required - if they're already unique, use the names directly from Azure.

The current approach is generating some long names with odd repetitions.

It seems like [asoctl importing] the resource group gets the correct owner, but pointing at the CosmosDB Database Account duplicates it wrongly
owner:
name: bulksend-cosmosdb-preview-nld2-bulksend-cosmosdb-preview-nld2 (edited)

Additional context

Reported on Slack.

@theunrepentantgeek theunrepentantgeek added cx-request Requests from customers received through non-GitHub channels and removed needs-triage 🔍 labels Oct 16, 2024
@theunrepentantgeek theunrepentantgeek self-assigned this Nov 14, 2024
@theunrepentantgeek theunrepentantgeek added this to the v2.12.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cx-request Requests from customers received through non-GitHub channels
Projects
Development

No branches or pull requests

1 participant