Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting AzureName if it is currently blank #4306

Open
theunrepentantgeek opened this issue Sep 30, 2024 · 0 comments · May be fixed by #4460
Open

Allow setting AzureName if it is currently blank #4306

theunrepentantgeek opened this issue Sep 30, 2024 · 0 comments · May be fixed by #4460
Assignees
@theunrepentantgeek
Milestone
v2.12.0

Comments

@theunrepentantgeek
Copy link
Member

theunrepentantgeek commented Sep 30, 2024 •
edited
Loading

Describe the current behavior

Currently our validation blocks any change to AzureName because this can't be changed in Azure.

However, this also blocks the case of setting AzureName when it's empty (which can occur if the webhooks fail).

Describe the improvement

Allow AzureName to be changed if it's currently empty, allowing users to self-correct if something goes wrong (see #4285 for an example where this would have been useful).

Additional context

We'll probably need to clear the annotation with the resource ID as well, as that will need to be regenerated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theunrepentantgeek theunrepentantgeek

Labels
None yet
Projects
Azure Service Operator Roadmap
Status: In Progress
Milestone
v2.12.0
Development

Successfully merging a pull request may close this issue.

Allow recovery if resources have a missing AzureName Azure/azure-service-operator
2 participants
@theunrepentantgeek @matthchr