Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Analytics] "Run no tests in weekly pipeline (Run tests<1s)" on Public, UsGov and China cloud #20971

Closed
v-xuto opened this issue Sep 30, 2021 · 10 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics MQ This issue is part of a "milestone of quality" initiative. test-manual-pass

Comments

@v-xuto
Copy link
Member

v-xuto commented Sep 30, 2021

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Error Description:
Run no text analytics tests in weekly pipeline, the message is shown as following, for more details please check here:
image

But I found that the main branch can run text analytics tests normally in nightly pipeline, for more details please check here
image

Expected Behavior:
Able to run text analytics tests normally. What configuration is missing in the Text Analytics weekly pipeline? Or is it some other reason?

@benbp, @jameszliao-msft, @lmazuel, @meeraharidasa , @mayurid, @abhahn for notification.

@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Cognitive - Text Analytics test-manual-pass labels Sep 30, 2021
@kristapratico kristapratico removed the needs-team-triage Workflow: This issue needs the team to triage. label Sep 30, 2021
@kristapratico kristapratico self-assigned this Sep 30, 2021
@kristapratico
Copy link
Member

Hey @v-xuto as far as I know, a test-weekly pipeline that runs in usgov/china has not yet been created for Text Analytics. Let me check with the feature crew to see if other languages regularly test in those clouds. This might be something we add for MQ.

@kristapratico kristapratico added the MQ This issue is part of a "milestone of quality" initiative. label Oct 6, 2021
@lmazuel lmazuel added this to the [2021] December milestone Oct 7, 2021
@v-xuto
Copy link
Member Author

v-xuto commented Oct 8, 2021

@kristapratico Okay, thanks for your help. I will be waiting for your news.

@kristapratico
Copy link
Member

@v-xuto Sorry for the delay. Checked with other language owners and this is something we want to enable across languages for Text Analytics. I added as an MQ item to get this configured and running weekly.

I understand that you are going through and validating tests on the pipeline so I want to make sure I don't step on your work. Can you get me up to speed on what's been done for python and what I can do to help here? I can make updates to the test-resources.json if you haven't already. Let me know!

@v-xuto
Copy link
Member Author

v-xuto commented Oct 11, 2021

@kristapratico My question is that when I ran a multi-cloud test on the weekly pipeline, no tests were actually run here in the Run Tests section. I don't know why this is the case here? I want you to help see why this is the case here?

@benbp Do you have any ideas?

@kristapratico
Copy link
Member

@v-xuto can you send the link about the build you mentioned? I can't find it. I see that someone created a tests - weekly pipeline for python text analytics here, but I don't see any runs yet.

It also doesn't look like we specify CloudConfig in our tests.yml file so my guess is that text analytics is currently only set up to run in prod regions. I think we can probably check how other languages are configured to set this up for Python. For example, this PR in .NET seems to have the necessary changes to enable multi-cloud testing: https://github.com/Azure/azure-sdk-for-net/pull/24583/files

Would you like me to open a PR with those changes?

@benbp
Copy link
Member

benbp commented Oct 12, 2021

@kristapratico the CloudConfig parameter is only necessary if you want to override location or test matrix filters/replace queries on a per environment basis. Otherwise, the only required field is SupportedClouds to add additional clouds to the weekly pipeline (see internal wiki).

I am now seeing runs on the pipeline you linked, but Run Tests is no longer skipped. @v-xuto is this issue still relevant?

@v-xuto
Copy link
Member Author

v-xuto commented Oct 13, 2021

@kristapratico @benbp We update BuildTargetingString: $(BuildTargetingString) to BuildTargetingString: azure-ai-textanalytics in our PR. Judging from the results of the pipeline, the problem seems to be solved. Is this the correct way to solve this issue? If so, I will close this issue. The screenshot below is the modification we made.
image

Text Analytics weekly pipeline result: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1138437&view=results

@benbp
Copy link
Member

benbp commented Oct 13, 2021

@v-xuto yes it looks like some of the python pipelines had BuildTargetingString set as a pipeline variable rather than hardcoded in the tests.yml file, and that pipeline variable wasn't set on the weekly pipeline as must have been manually added. It looks like digitaltwins and search also have this issue, and BuildTargetingString can also be changed to the appropriate strings for those as well. I have fixes for those here: #21241

image

@kristapratico
Copy link
Member

Thanks for the help @benbp!

@v-xuto are the text analytics tests passing for sovereign clouds or is there still some work here?

@v-xuto
Copy link
Member Author

v-xuto commented Oct 14, 2021

@kristapratico @benbp This issue has been resolved, I will close it.

@v-xuto v-xuto closed this as completed Oct 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics MQ This issue is part of a "milestone of quality" initiative. test-manual-pass
Projects
None yet
Development

No branches or pull requests

4 participants