Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to stable API 2024-09-20 #8343

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chrisribe
Copy link
Member

@chrisribe chrisribe commented Nov 27, 2024

This PR updates the healthcareapis deidservice az cli extension to use our stable API version (2024-09-20).
Bump version to 1.0.1 in history.rst and setup.py


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 27, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @chrisribe,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 27, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@chrisribe chrisribe marked this pull request as ready for review November 27, 2024 20:57
Copy link

github-actions bot commented Nov 27, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 27, 2024
@chrisribe
Copy link
Member Author

chrisribe commented Nov 27, 2024

For reference the related AAZ PR: Azure/aaz#636
Please add someone on there to review, it seems to not add anyone and is locked down.

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 27, 2024
@chrisribe
Copy link
Member Author

@yonzhan bump ;)

@chrisribe chrisribe requested a review from kairu-ms December 4, 2024 15:08
@kairu-ms
Copy link
Contributor

kairu-ms commented Dec 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@chrisribe
Copy link
Member Author

@kairu-ms I was getting "except CannotOverwriteExistingCassetteException"
https://dev.azure.com/azclitools/public/_build/results?buildId=209911&view=logs&j=155127ab-52f1-52e7-0e45-625d9d7884a4&t=4bb67950-ef03-52d4-44f5-d1a8cd56c919&l=663

I re-recorded the test in --live mode and that updated with azcli 2.67 calls and fixed the errors.
Another /azp run may be required.... ?

@kairu-ms
Copy link
Contributor

kairu-ms commented Dec 9, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot extension/healthcare az healthcareapis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants