Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace email address for test recording files #8316

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

evelyn-ys
Copy link
Member

@evelyn-ys evelyn-ys commented Nov 25, 2024

Secrets have been handled in #8358
So this PR is for email addresses only


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 25, 2024

❌Azure CLI Extensions Breaking Change Test
❌firmwareanalysis
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate firmwareanalysis firmware create cmd firmwareanalysis firmware create update parameter firmware_id: updated property aaz_default from f586dbee-5156-4e29-9b0e-dee8eebc073a to a0675be7-2f1e-4692-95b2-5b681c52b41f please change property aaz_default from a0675be7-2f1e-4692-95b2-5b681c52b41f to f586dbee-5156-4e29-9b0e-dee8eebc073a for parameter firmware_id of cmd firmwareanalysis firmware create
1010 - ParaPropUpdate firmwareanalysis firmware create cmd firmwareanalysis firmware create update parameter firmware_id: updated property default from f586dbee-5156-4e29-9b0e-dee8eebc073a to a0675be7-2f1e-4692-95b2-5b681c52b41f please change property default from a0675be7-2f1e-4692-95b2-5b681c52b41f to f586dbee-5156-4e29-9b0e-dee8eebc073a for parameter firmware_id of cmd firmwareanalysis firmware create

Copy link

Hi @evelyn-ys,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 25, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@yonzhan yonzhan added this to the Backlog milestone Nov 25, 2024
@evelyn-ys evelyn-ys changed the title Replace secrets for test recording files Replace secret & email address for test recording files Dec 5, 2024
@evelyn-ys evelyn-ys changed the title Replace secret & email address for test recording files Replace email address for test recording files Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants