Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vm-repair} Overhaul VM Repair examples #8294

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Nov 18, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 18, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Sandido,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

github-actions bot commented Nov 18, 2024

Hi @Sandido

Release Suggestions

Module: vm-repair

  • Update VERSION to 2.0.2 in src/vm-repair/setup.py

Notes

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2024

VM Repair

@Sandido Sandido changed the title Overhaul VM Repair examples {vm-repair} Overhaul VM Repair examples Nov 22, 2024
@Sandido
Copy link
Member Author

Sandido commented Nov 22, 2024

@zhoxing-ms , @yanzhudd , please review.

@yanzhudd
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Contributor

Hi @Sandido
please resolve the code conflicts

@Sandido
Copy link
Member Author

Sandido commented Nov 27, 2024

@yanzhudd please re-review

src/vm-repair/HISTORY.rst Outdated Show resolved Hide resolved
taking comment suggestion, new to using 'upcoming' though.

Co-authored-by: Yan Zhu <[email protected]>
@Sandido
Copy link
Member Author

Sandido commented Dec 2, 2024

@yanzhudd , I committed your suggestions. I am not familiar with using Upcoming as a version though. If that is the new best practice, then that's good by me. Else 2.0.2 is fine.

@yanzhudd
Copy link
Contributor

yanzhudd commented Dec 3, 2024

@yanzhudd , I committed your suggestions. I am not familiar with using Upcoming as a version though. If that is the new best practice, then that's good by me. Else 2.0.2 is fine.

If you put features into upcoming, the features are currently in a pending release status. You can move them to a new version later like 2.0.2 when you want to release them.

@yanzhudd
Copy link
Contributor

yanzhudd commented Dec 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Sandido
Copy link
Member Author

Sandido commented Dec 3, 2024

@yanzhudd , do I need to do anything to manually release a new version of the cli extension or does the cli team do that automatically?

@yanzhudd
Copy link
Contributor

yanzhudd commented Dec 4, 2024

@yanzhudd , do I need to do anything to manually release a new version of the cli extension or does the cli team do that automatically?

You can determine when to release a new version and what version will be. The extension module is flexible and can be controlled by yourself.
You need to modify the HISTORY.rst and setup.py files if you want to release a new version for it (You can refer to this PR: https://github.com/Azure/azure-cli-extensions/pull/8000/files). After the modification, the new version will be released automatically in about a tens of minutes.

However, please note that all releases are currently frozen due to CCOA, so please do not release any version for now.

@yanzhudd
Copy link
Contributor

yanzhudd commented Dec 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd closed this Dec 4, 2024
@yanzhudd yanzhudd reopened this Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants