Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az aks draft up | In in-line help, provide list of azCLI reference commands being executed #8061

Closed
dbradish-microsoft opened this issue Mar 14, 2024 · 9 comments
Labels
AKS Auto-Assign Auto assign by bot Auto-Resolve bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention This issue is responsible by Azure service team. Similar-Issue

Comments

@dbradish-microsoft
Copy link
Contributor

Describe the bug

Customers are asking what Azure CLI reference commands are being executed by our az ... up commands. Doc writers are also requesting this information when they must replicate Azure CLI docs with Azure PowerShell commands. Although the reference list might change based on the parameters being passed, we need clarity in our in-line help and resulting autogenerated reference content.

Reference command link: https://learn.microsoft.com/en-us/cli/azure/aks/draftt#az-aks-draft-up

Current description:
(This description is actually more helpful than some of the other up descriptions, but it needs to tell customers all of the azCLI commands being executed.)
image

REQUEST: Please modify this description to list each Azure CLI reference command that "up" can/is executing.

Possible impacted source code files:
https://github.com/azure/azure-cli-extensions/blob/main/src/aks-preview/azext_aks_preview/_help.py

Related command

az aks draft up

Errors

This bug is being entered to eliminate customer confusion by adding clarity to our help content.

Issue script & Debug output

n/a

Expected behavior

n/a

Environment Summary

Azure CLI 2.58.0

Additional context

No response

@dbradish-microsoft dbradish-microsoft added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 14, 2024
Copy link

Hi @dbradish-microsoft
Find similar issue #8060.

Issue title az aks app up
Create time 2024-03-14
Comment number 0

Please confirm if this resolves your issue.

@microsoft-github-policy-service microsoft-github-policy-service bot added AKS Service Attention This issue is responsible by Azure service team. Auto-Assign Auto assign by bot labels Mar 14, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 14, 2024

Thank you for opening this issue, we will look into it.

Copy link
Contributor

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @dyu1208, @FumingZhang, @andyliuliming.

@dbradish-microsoft
Copy link
Contributor Author

@dyu1208, @FumingZhang, @andyliuliming.

Can we resolve this issue by putting a sentence in the short or long summary that states something like "Run this command with the --debug parameter to see the API calls and parameters values being used."?

This avoids a lengthy long-summary property, but tells the customer how to find the answer for themselves.

@FumingZhang
Copy link
Member

@karenychen to help

From my understanding, this command basically does not call ARM, but executes the draft program/binary.

@karenychen
Copy link
Contributor

Hi @dbradish-microsoft, aks draft up only runs the setup-gh and the generate-workflow command. I have updated the short summary to include them. Please let me know if this fix looks good, thanks!

@dbradish-microsoft
Copy link
Contributor Author

@karenychen, do you have a link to your PR that reflects the update?

@karenychen
Copy link
Contributor

HI @dbradish-microsoft, PR link is mentioned in this thread. PR link: #7782

@dbradish-microsoft dbradish-microsoft transferred this issue from Azure/azure-cli Oct 7, 2024
@dbradish-microsoft
Copy link
Contributor Author

@karenychen, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot Auto-Resolve bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention This issue is responsible by Azure service team. Similar-Issue
Projects
None yet
Development

No branches or pull requests

4 participants