Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Provide ARM VM support for vm-repair extension #5826

Closed
malachma opened this issue Feb 1, 2023 · 14 comments
Closed

Feature Request: Provide ARM VM support for vm-repair extension #5826

malachma opened this issue Feb 1, 2023 · 14 comments
Assignees
Labels
Compute extension/vm-repair feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team.

Comments

@malachma
Copy link
Member

malachma commented Feb 1, 2023

Extension name (the extension in question)

vm-repair

Description of issue (in as much detail as possible)

In order to use the 'vm repair' extension to work with ARM based VMs the extension needs to create the right recovery VM.
At the moment ARM based VMS aren't supported. At creation time the following error is raised

ERROR: {"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"BadRequest","message":"{\r\n "error": {\r\n "code": "BadRequest",\r\n "message": "Cannot create a VM of size 'Standard_D2pls_v5' because this VM size only supports a CPU Architecture of 'Arm64', but an image or disk with CPU Architecture 'x64' was given. Please check that the CPU Architecture of the image or disk is compatible with that of the VM size."\r\n }\r\n}"}]}}

@yonzhan yonzhan added Compute CXP Attention This issue is handled by CXP team. labels Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Thank you for your feedback. This has been routed to the support team for assistance.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 1, 2023

route to CXP team

@navba-MSFT navba-MSFT added Service Attention This issue is responsible by Azure service team. needs-team-attention This issue needs attention from Azure service team or SDK team feature-request This issue requires a new behavior in the product in order be resolved. and removed CXP Attention This issue is handled by CXP team. labels Feb 2, 2023
@ghost
Copy link

ghost commented Feb 2, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv, @Vaibhav-Agar, @amjads1.

Issue Details

Extension name (the extension in question)

vm-repair

Description of issue (in as much detail as possible)

In order to use the 'vm repair' extension to work with ARM based VMs the extension needs to create the right recovery VM.
At the moment ARM based VMS aren't supported. At creation time the following error is raised

ERROR: {"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"BadRequest","message":"{\r\n "error": {\r\n "code": "BadRequest",\r\n "message": "Cannot create a VM of size 'Standard_D2pls_v5' because this VM size only supports a CPU Architecture of 'Arm64', but an image or disk with CPU Architecture 'x64' was given. Please check that the CPU Architecture of the image or disk is compatible with that of the VM size."\r\n }\r\n}"}]}}

Author: malachma
Assignees: -
Labels:

Compute, Service Attention, needs-team-attention, feature-request

Milestone: -

@navba-MSFT
Copy link
Contributor

Adding service team to look into this ask.

@Drewm3, @avirishuv, @Vaibhav-Agar, @amjads1 Could you please look into this once you get a chance ? Thanks in advance.

@Drewm3 Drewm3 self-assigned this Feb 2, 2023
@Drewm3
Copy link
Member

Drewm3 commented Feb 3, 2023

Moving this to myself to find the right current owner of the VM Repair tool.

@Drewm3 Drewm3 assigned haagha and unassigned Drewm3 Mar 23, 2023
@Drewm3
Copy link
Member

Drewm3 commented Mar 23, 2023

Updating to the tool owner

@malachma
Copy link
Member Author

malachma commented Jul 3, 2023

What is the progress on this feature requests? ARM64 support is a feature which also benefits our self-service capabilities

Copy link
Contributor

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @TravisCragg-MSFT, @nikhilpatel909, @sandeepraichura, @hilaryw29, @GabstaMSFT, @ramankumarlive, @ushnaarshadkhan.

@haagha haagha removed their assignment Aug 29, 2024
@TravisCragg-MSFT TravisCragg-MSFT self-assigned this Aug 29, 2024
@TravisCragg-MSFT
Copy link
Member

@malachma We are currently assessing this as a feature request and will post an update when we can.

@Sandido
Copy link
Member

Sandido commented Sep 3, 2024

This issue was previously resolved and should be available in recent versions of Azure CLI.

@Sandido Sandido closed this as completed Sep 3, 2024
@malachma
Copy link
Member Author

I'm not able to confirm that this is solved. You just have created a new issue by not testing this new feature correctly. Creating an ARM64 recover VM throws the following error for a 'Standard Security' enabled VM

{
"error_message": "ERROR: {"status":"Failed","error":{"code":"DeploymentFailed","target":"/subscriptions/3aa7d10a-70b7-4a97-9350-10f90dca8d4e/resourceGroups/repair-ubuntu24-ade-20240923080908/providers/Microsoft.Resources/deployments/vm_deploy_0dfmaYNE1uObnlSzkcONTXG1eIqVZxeZ","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"BadRequest","message":"Use of TrustedLaunch setting is not supported for the provided image. Please select Trusted Launch Supported Gen2 OS Image. For more information, see https://aka.ms/TrustedLaunch-FAQ."}]}}\n",
"message": "Repair create failed. Cleaning up created resources.",
"status": "ERROR"
}

@haagha
Copy link
Member

haagha commented Sep 24, 2024

Hi @malachma this is a known issue in underlying CLI, we will create a bug to resolve this. Azure/azure-cli#27975

@Sandido
Copy link
Member

Sandido commented Sep 24, 2024

@malachma , you can ping Haider for more info about testing the current fix for this issue.

What is your repro? I tried to create a repair vm from an ARM64 vm and setting the repair vm explicitly to an arm64 image, but the repair vm was made successfully.
C:\Users\XXXXX\source\repos\XXXXX> az vm repair create -g $rgname -n $vmname --repair-username XXXXX --repair-password XXXXX --yes --verbose --distro "Canonical:0001-com-ubuntu-server-jammy:22_04-lts-arm64:latest"
Fetching architecture type of the source VM...
Checking if source VM is gen2
Generation 2 VM detected
A custom URN was provided , will be used as distro for the recovery VM
ARM64 VM detected
A custom URN was provided , will be used as distro for the recovery VM
Checking if source VM size is available...
Source VM size 'Standard_D2pls_v5' is available. Using it to create repair VM.

Checking for existing resource groups with identical name within subscription...
Pre-existing repair resource group with the same name is 'False'
Creating resource group for repair VM and its resources...
Source VM uses managed disks. Creating repair VM with managed disks.

Copying OS disk of source VM...
Creating repair VM with command: az vm create -g repair-vm64std-XXXXX -n repair-vm64std_ --tag repair_source=XXXXX/vm64std --image Canonical:0001-com-ubuntu-server-jammy:22_04-lts-arm64:latest --admin-username XXXXX --admin-password XXXXX --public-ip-address False --custom-data c:\users\XXXXX\source\repos\XXXXX\azure-cli-extensions\src\vm-repair\azext_vm_repair\scripts\linux-build_setup-cloud-init.txt --size Standard_D2pls_v5
copy_disk_id: /subscriptions/XXXXX/resourceGroups/XXXXX/providers/Microsoft.Compute/disks/vm64std-DiskCopy-XXXXX
repair_password: XXXXX
repair_username: XXXXX
fix_uuid: True
Validating VM template before continuing...
Creating repair VM...
Attaching copied disk to repair VM as data disk...

Your repair VM 'repair-vm64std_' has been created in the resource group 'repair-vm64std-XXXXX' with disk 'vm64std-DiskCopy-XXXXX' attached as data disk. Please use this VM to troubleshoot and repair. Once the repairs are complete use the command 'az vm repair restore -n vm64std -g XXXXX --verbose' to restore disk to the source VM. Note that the copied disk is created within the original resource group 'XXXXX'.

@malachma
Copy link
Member Author

Hi @malachma this is a known issue in underlying CLI, we will create a bug to resolve this. Azure/azure-cli#27975

Thanks Haider :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute extension/vm-repair feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

7 participants