Create rule "Local message queue or message hub"

[agoncal]

This rule highlights use of on-premises message queues which will need replaced with Azure alternatives such as Azure Service Bus or Azure Storage Queues. Specific patterns for identifying these vary based on the specific dependencies, but the most common are:

• Use of the RabbitMQ.Client namespace which would indicate use of a local RabbitMQ instance.
• Use of the MassTransit.Bus.Factory.CreateUsingRabbitMq API which also indicates RabbitMQ use.
• Use of Microsoft.ServiceBus.Messaging APIs with a connection string of the form sb://<host>/<namespace> (as opposed to sb://<namespace>.servicebus.windows.net). This one is a bit nuanced because Microsoft.ServiceBus.Messaging might be used to connect to either on-premises Service Bus instances or Azure-hosted ones, and only on-premises service bus usage is problematic.

These metadata are interesting to both Azure App Service and containerized targets.

Java specific things to review:

• Usage of JMS, look for javax.jms package usage
• Usage of Apache MQ / Rabbit MQ clients or other 3rd party clients

Existing WindUp Rules

• https://github.com/windup/windup-rulesets/blob/master/rules/rules-reviewed/azure/springboot/spring-boot-to-azure-jms-broker.windup.xml
• https://github.com/windup/windup-rulesets/blob/master/rules/rules-reviewed/azure/springboot/spring-boot-to-azure-mq-config.windup.xml
• https://github.com/windup/windup-rulesets/blob/master/rules/rules-reviewed/technology-usage/connect.windup.groovy

Existing Azure Documentation

• https://learn.microsoft.com/en-us/azure/developer/java/migration/migrate-tomcat-to-tomcat-app-service#inventory-external-resources
• https://learn.microsoft.com/azure/developer/java/migration/migrate-spring-boot-to-azure-spring-apps#jms-message-brokers
• https://docs.microsoft.com/azure/service-bus-messaging/service-bus-messaging-overview
• https://azure.microsoft.com/solutions/messaging-services

WindUp Discovered Messaging Services

The connect.windup.groovy technology rule already checks for:

• ActiveMQ
• RabbitMQ
• Spring Messaging Client
• Amazon SQS Client
• HornetQ Client
• AMQP Client
• RocketMQ Client
• 0MQ Client
• JBossMQ Client
• Kafka Client

Supported Azure Messaging Services

• Service Bus
• Event Grid
• Event Hubs
• Queue Storage

PRs

Beta Give feedback

1. Overrides ActiveMQ messaging rule windup-rulesets#53
   rule +1
   
2. Renumbering Connect rules so it's easier to override windup/windup-rulesets#979
   +0
3. Overrides the existing Kafka rule #114
   rule +1
   

[showpune]

We need to think it from serveral layer

1. Message server you are using ( rabbit, kalfka): jar file and configuration file
2. message framework: jms, spring-message: jar file and configuration
   jms is server independent, but spring-message sometime is server dependent, like
3. in server bus, the annotation ServiceBusListener
4. in rabbitmq, the annothation RabbitListener

[agoncal]

We already have a SpringBoot rule on MQ: https://github.com/Azure/windup-rulesets/blob/main/rules/rules-reviewed/azure/springboot/spring-boot-to-azure-mq-config.windup.xml

@brunoborges @showpune as we only have an Active MQ rule for now, shall we create/override rules on:

• Rabbit MQ
• Kalfka

[brunoborges]

I think Kafka is a must for the MVP.

[agoncal]

PR on its way: #114