Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udev: move the rules on systemd-enabled platforms to /usr/lib/udev #1621

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lkundrak
Copy link

@lkundrak lkundrak commented Aug 27, 2019

Description

The /etc directory contains user configuration, potentially overriding
the vendor-supplied rules that go to /usr/lib.

Let's prefer that directory on platforms that use systemd; we can be sure
that those platforms support rules in /usr/lib.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

The /etc directory contains user configuration, potentially overriding
the vendor-supplied rules that go to /usr/lib.

Let's prefer that directory on platforms that use systemd; we can be sure
that those platforms support rules in /usr/lib.
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@89e2b8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1621   +/-   ##
==========================================
  Coverage           ?   66.17%           
==========================================
  Files              ?       78           
  Lines              ?    11175           
  Branches           ?     1578           
==========================================
  Hits               ?     7395           
  Misses             ?     3445           
  Partials           ?      335

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e2b8c...424033c. Read the comment docs.

@lkundrak
Copy link
Author

lkundrak commented Sep 13, 2019

Hello?
Is there anybody out there?

@lkundrak
Copy link
Author

Just nod if you can hear me

@lkundrak
Copy link
Author

Is there anyone home?

@narrieta
Copy link
Member

@trstringer could you take a look? thanks!

@narrieta narrieta removed their request for review October 29, 2019 22:42
@narrieta narrieta assigned trstringer and unassigned narrieta Oct 29, 2019
@lkundrak
Copy link
Author

lkundrak commented Nov 7, 2019

hello hello hello hello

@lkundrak
Copy link
Author

ping ping

@lkundrak
Copy link
Author

hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants