Add support for versions/activities (#209) and partial support for SharePoint pages (#190) #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
list_activities added to both ms_drive_item objects and ms_drive objects
Add get_analytics, list_columns, list_permission, and list_content_types methods to ms_site objects
Also expose simplify parameter for get_column_info method
Add missing Encoding: UTF-8
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably an over-crowded PR but I wanted to confirm that I hadn't forgotten about our exchange on here back in February @hongooi73. I've been adding methods that I'm trying out for my wrapper sharepointr package to my branch and figured I'd open a PR.
Here are the changes in this PR so far:
simplifyargument forms_list$get_column_info()method.ms_list$create_link()method for creating a shared link to a list item.ms_list$create_column()method.ms_site$get_pages()method (Add support for SharePoint Pages #190)ms_site$get_analytics(),ms_site$list_permissions(), andms_site$list_content_types()methods. (Add newms_drive_itemmethods for item version history, analytics, retention labels, etc. #188)ms_drive$list_activities()(Add newms_drive_itemmethods for item version history, analytics, retention labels, etc. #188)I'm marking this PR as a draft because there are several additional changes that I know are still needed:
ms_list(may require a helper function for validation or help prepping a definition)ms_site$get_pages()method (I can't recall the difference between the two API endpoints - since I wrote that part a month or two ago)I can split this up into multiple PRs if needed or make other changes as appropriate.