Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: allow overriding private DNS zones in complete_multi_region #244

Open
1 task done
jaredfholgate opened this issue Nov 8, 2024 · 1 comment
Open
1 task done
Labels
Type: Enhancement ✨ New feature or request

Comments

@jaredfholgate
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Infrastructure as Code Type? (Required)

terraform

Starter Module? (Required)

terraform - complete_multi_region

Use Case (Required)

As a user I'd like to override the DNS zones that are deployed.

Proposed Solution (Required)

Allow a parameter to be used instead of null here: https://github.com/Azure/alz-terraform-accelerator/blob/aeaa83416a1c58ee8524bf6aa3117c6395865c64/templates/complete_multi_region/modules/hub-and-spoke-vnet/main.tf#L55

This will allow users to override the list of DNS zones deployed.

Important Factoids (Optional)

No response

References (Optional)

No response

@jaredfholgate jaredfholgate added Needs: Triage 🔍 Needs triaging by the team Type: Enhancement ✨ New feature or request and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 8, 2024
@jaredfholgate
Copy link
Member Author

Good idea, will implement. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant