Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: GitHub PAT requires too many permissions #160

Open
terrymandin opened this issue Feb 23, 2024 · 1 comment
Open

Feature Request: GitHub PAT requires too many permissions #160

terrymandin opened this issue Feb 23, 2024 · 1 comment
Labels
Area: Bootstrap Modules 👢 Issues / PR's related to the Accelerator bootstrap modules Module: Bootstrap Type: Documentation 📄 Improvements or additions to documentation Type: Enhancement ✨ New feature or request

Comments

@terrymandin
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

My customer is concerned with the amount of permissions that the GitHub PAT requires and is specifically concerned with the admin:org and delete_repo permissions. They decided to deploy manually using the -c local option

Describe the solution you'd like

Provide options for the customer.

  • I believe that the delete_repo is only required for a terraform destroy command. We could mention that it is optional in the documentation.
  • For the admin:org option, modify the accelerator to use an existing approval team if it already exists. Then provide instructions to the customer as to how to create the team manually themselves.

Additional context

@jaredfholgate jaredfholgate transferred this issue from Azure/alz-terraform-accelerator Sep 2, 2024
@jaredfholgate jaredfholgate added Needs: Triage 🔍 Needs triaging by the team Type: Documentation 📄 Improvements or additions to documentation Area: Bootstrap Modules 👢 Issues / PR's related to the Accelerator bootstrap modules Module: Bootstrap Type: Enhancement ✨ New feature or request and removed Needs: Triage 🔍 Needs triaging by the team labels Sep 2, 2024
@jaredfholgate
Copy link
Member

These are good points. We can alter the documentation around the delete repo perm and add the option of supplying an existing team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Bootstrap Modules 👢 Issues / PR's related to the Accelerator bootstrap modules Module: Bootstrap Type: Documentation 📄 Improvements or additions to documentation Type: Enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants