-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of instruction to use PostgreSQL in the application #127
base: main
Are you sure you want to change the base?
Conversation
added documentation regarding the PostgreSQL usage instructions.
@Aryan-CC please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@@ -1,7 +1,7 @@ | |||
--- | |||
title: '3. MySQL database' | |||
title: '3.1 MySQL database' | |||
layout: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd better and children pages here
@@ -0,0 +1,80 @@ | |||
# COMMON APPLICATION PROPERTIES | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to reduce duplicated configuration, we should not copy all content of the yaml
|
||
```bash | ||
az mysql flexible-server connect -n $MYSQL_SERVER_NAME -u myadmin -p $MYSQL_ADMIN_PASSWORD --interactive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upper case? this variable is defined in 0203.md
@@ -0,0 +1,74 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a good idea to add new lab for postgres sql
Seems the configuration differences are minor for MySQL & PostgresSQL, I think we may replace MySQL with PostgresSQL in the main thread, and use a Optional page to describe the differences for MySQL
Too much redundant changes, we may use a more straight way |
Purpose
As the application supports both MySQL and PostgreSQL Database options, added instructions for usage of PostgresSQL.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?