Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: document private log limits #439

Open
Tracked by #220
critesjosh opened this issue Nov 3, 2024 · 0 comments
Open
Tracked by #220

[docs]: document private log limits #439

critesjosh opened this issue Nov 3, 2024 · 0 comments

Comments

@critesjosh
Copy link
Collaborator

Note in docs that private logs to have at most 8 fields.

  • For notes: 1 for storage slot, 1 for note type id, and 6 for custom fields.
  • For events: 1 for storage slot, 1 for event type id, 1 for address tag, and 5 for custom fields.
    This is to make it more difficult to figure out what a tx is about when all the logs are the same length. In the current codebase, the max number of custom fields is 4 for note, and 5 for event. We can adjust the limit to allow more custom fields if necessary.

associated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant