Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove top-level await from aztec.js #9959

Open
Tracked by #8881
olehmisar opened this issue Nov 14, 2024 · 0 comments · May be fixed by #10128
Open
Tracked by #8881

Remove top-level await from aztec.js #9959

olehmisar opened this issue Nov 14, 2024 · 0 comments · May be fixed by #10128
Labels
from-community This originated from the community :)

Comments

@olehmisar
Copy link
Contributor

@ludamad per our private conversation, we agreed that BarretenbergSync should be nuked for this issue to be resolved.

It will make Ecdsa, Secp256k1, Aes and Schnorr class methods async. And some other methods like poseidonHash will also have to be made async. It's better to make this change sooner than later because it is a breaking change
@olehmisar olehmisar mentioned this issue Nov 14, 2024
Open
@critesjosh critesjosh added the from-community This originated from the community :) label Nov 19, 2024
@olehmisar olehmisar linked a pull request Nov 21, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
from-community This originated from the community :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: nuke top level await olehmisar/aztec-packages
2 participants
@critesjosh @olehmisar