Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to express it in words #4

Open
Dg32z opened this issue Nov 7, 2024 · 7 comments
Open

No need to express it in words #4

Dg32z opened this issue Nov 7, 2024 · 7 comments

Comments

@Dg32z
Copy link

Dg32z commented Nov 7, 2024

Describe the false positive and how to replicate it

2024-11-08.00-16-57.mp4

Grim version

ver GrimAC
[00:18:29 INFO]: GrimAC version 2.3.69
[00:18:29 INFO]: Libre simulation anticheat designed for 1.21 with 1.8-1.21 support, powered by PacketEvents 2.0.
[00:18:29 INFO]: Website: https://grim.ac/
[00:18:29 INFO]: Author: GrimAC

Server version

[00:19:11 INFO]: Checking version, please wait...
[00:19:13 INFO]: This server is running Paper version git-Paper-497 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: d8d54d9 on ver/1.20.4)
You are 2 version(s) behind
Download the new version at: https://papermc.io/downloads/paper
Previous version: 1.21.1-128-d348cb8 (MC: 1.21.1)

Client version

vanilla 1.20.4

Plugins

[00:19:24 INFO]: Server Plugins (9):
[00:19:24 INFO]: Bukkit Plugins:
[00:19:24 INFO]: - Apollo-Bukkit, Citizens, GrimAC, LiteBans, LuckPerms, LunarPlugin, PlaceholderAPI, PlugManX, SimpleChat

@Axionize
Copy link
Owner

Axionize commented Nov 12, 2024

Thank you. I'll look into it in a few days when I have time.

EDIT: Are you left and right clicking at the same time? Right clicking and then left clicking? left and then right? What exactly are you doing?

@Dg32z
Copy link
Author

Dg32z commented Nov 14, 2024

Thank you. I'll look into it in a few days when I have time.

EDIT: Are you left and right clicking at the same time? Right clicking and then left clicking? left and then right? What exactly are you doing?

left and right clicking at the same time

@Axionize
Copy link
Owner

After careful investigation, this appears to have to the same cause as the AirLiquidPlace false. This is an engine limitation (I think it's fixed in V3?) and there's not much I can do about this if you want a quick fix besides copying a model of the world that's 1 tick behind and checking against both that model and the current world model.

You'll either have to bear the cost of 2 async world models per player which would be utterly awful for performance and memory, or you'll have to wait for V3.

I have a few ideas of how to exempt instant break blocks from causing these falses but it'll take some time before I implement them. This will likely not be fixed for at least a few weeks but It's on my todo list.

@Axionize
Copy link
Owner

UPDATE: I came up with a new idea to fix this while doing something else. Will try to implement next week.

@Axionize
Copy link
Owner

B11 does not fully fix this but it does mitigate the issue and make it harder to trigger.

@Axionize
Copy link
Owner

I've fixed a very similar issue with AirLiquidPlace. I'll be porting over that fix to LOSP eventually.

@Axionize
Copy link
Owner

This has been further mitigated in B39. Still possible to false but if you were to do this again you might get 1 or 2 falses in this video instead of every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants