-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message | create OO for the MESSAGE feature #1
Labels
Task
New feature or request
Comments
AvocadoStyle
added a commit
that referenced
this issue
Apr 29, 2024
AvocadoStyle
added a commit
that referenced
this issue
Apr 29, 2024
AvocadoStyle
added a commit
that referenced
this issue
May 4, 2024
AvocadoStyle
added a commit
that referenced
this issue
May 4, 2024
…creation #1 Will use this branch as the message infrastruture branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
As we can see in
OkCupidSelenium
class Themessage
method contains the message sending, We'll want to split it to a methods and use correct OO programming to do so, Right now it's messy and we're always maintance this code with high efford.Design
Top Down Design
Use the
initialize_objects
method inside theOkCupidSelenium
class and Initialize aself.message_action
.Inside Message Entity We'll have
browser_action
- just likeclass Like
has, Which will help us to manipulate the browsing events.Every Message Event will have it's own method just like
send_message
, And even edge cases like unable to send a message - We'll perform steps of fallback in this case, And more.The text was updated successfully, but these errors were encountered: