Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used Recoil for toggletheme #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AADESHak007
Copy link

Closes:

  • Title : Optimization in code structure
  • Name: AADESHak007
  • Idenitfy yourself: GSSOC-extd Contributor 2024

Describe the add-ons or changes you've made 📃

This Fixes #358

Earlier the context API was used to toggle theme . I have used RECOIL js to to change the theme of the website .
This will enhance the loading speed of the website and will reduce the number of re rendering .
Will make this a more robust Client side rendering App .

I did not touched the ProgressBar code because of the following reasons :
  • it is not being used at many places .
  • using Recoil for it wouldn't make that big of a difference
    conclusion: it was not the case where you would use RECOIL .

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screen.Recording.2024-10-30.212133.mp4

Note to reviewers 📄

Copy link

vercel bot commented Oct 30, 2024

@AADESHak007 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:53am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts before 5 pm

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requested Changes ⚙️ Some changes have been requested in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Optimization in CODE STRUCTURE
2 participants