Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat control should support images #1314

Closed
1 of 6 tasks
AlexandreSajus opened this issue May 24, 2024 · 42 comments · Fixed by #2078 · May be fixed by #2268
Closed
1 of 6 tasks

Chat control should support images #1314

AlexandreSajus opened this issue May 24, 2024 · 42 comments · Fixed by #2078 · May be fixed by #2268
Labels
🖰 GUI Related to GUI hacktoberfest - 300💎💎💎 Issues rewarded by 300 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed ⚔️ Quest Tracks quest-bot quests

Comments

@AlexandreSajus
Copy link
Contributor

AlexandreSajus commented May 24, 2024

Description

The chat control of #1092 is really cool! It would be a good addition to support images in the messages of the chat. This would be especially useful since now LLMs start supporting image vision and image generation. I could create cool demos around this chat control.

Florian:
People are also using chat demos to visualize tables inside their chat. This could also be a nice addition.

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Create related issue in taipy-doc for documentation and Release Notes.
  • Check if a new demo could be provided based on this, or if legacy demos could be benefit from it.
  • Ensure any change is well documented.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@AlexandreSajus AlexandreSajus added 🖰 GUI Related to GUI 🟩 Priority: Low Low priority and doesn't need to be rushed ✨New feature labels May 24, 2024
@jrobinAV jrobinAV added 📈 Improvement Improvement of a feature. and removed ✨New feature labels May 24, 2024
@jrobinAV jrobinAV changed the title [Feature] Chat control should support images Chat control should support images May 24, 2024
@jrobinAV jrobinAV added the 🆘 Help wanted Open to participation from the community label May 31, 2024
@ioannastantzou
Copy link

Hello there I think I could work on this issue!

@FlorianJacta
Copy link
Member

Great, I will assign it to you!

@ioannastantzou
Copy link

hello again! can you specify where the chat code exists?

@ioannastantzou
Copy link

ioannastantzou commented Jun 12, 2024

hello again! can you specify where the chat code exists?

is it taipy\frontend\taipy-gui\src\components\Taipy\chat.tsx ? @FabienLelaquais @FredLL-Avaiga

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jun 26, 2024
@yaten2302
Copy link
Contributor

yaten2302 commented Jun 26, 2024

Hey @FlorianJacta @AlexandreSajus , could you please assign this issue to me, if no one is working on this?

@FlorianJacta
Copy link
Member

@ioannastantzou is normally working on it. Could you confirm @ioannastantzou ?

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jun 27, 2024
@yaten2302
Copy link
Contributor

@ioannastantzou is normally working on it. Could you confirm @ioannastantzou ?

It's ok if someone is working on this, but if not I'm in 👍

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 12, 2024
@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 27, 2024
Copy link
Contributor

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@FlorianJacta FlorianJacta changed the title Chat control should support images Chat control should support images and tables Jul 30, 2024
@FlorianJacta FlorianJacta changed the title Chat control should support images and tables Chat control should support images (and tables) Jul 30, 2024
@yaten2302
Copy link
Contributor

Hey @FlorianJacta @AlexandreSajus , can this issue be assigned to me?

Also, I would like to ask that in here, do we've to add a files icon on the left side of the message box (similar to what is present in chatgpt)?

image


image

@FlorianJacta
Copy link
Member

What do you mean by a file icon?

Can this be assigned? @FredLL-Avaiga @FabienLelaquais

@AlexandreSajus AlexandreSajus removed the 🟩 Priority: Low Low priority and doesn't need to be rushed label Sep 9, 2024
@yaten2302
Copy link
Contributor

Thanks @FredLL-Avaiga , now it's working👍

Also, I wanted to ask about this comment, like for the chat to support, we need an icon to show the user to attach an image. Should I add an icon in the chat itself (as in chatGPT)?

@yaten2302
Copy link
Contributor

yaten2302 commented Oct 13, 2024

Also, I wanted to ask that in this PR #1092, you took a screenshot of the chat element, could you please guide that if I want to test the element locally, how can I view them? (as you've shown in this PR)

image

@FredLL-Avaiga
Copy link
Member

Also, I wanted to ask that in this PR #1092, you took a screenshot of the chat element, could you please guide that if I want to test the element locally, how can I view them? (as you've shown in this PR)

image

You create a simple python script and run it locally
You can find simple examples in doc/examples/gui

@FredLL-Avaiga
Copy link
Member

Thanks @FredLL-Avaiga , now it's working👍

Also, I wanted to ask about this comment, like for the chat to support, we need an icon to show the user to attach an image. Should I add an icon in the chat itself (as in chatGPT)?

I'm not sure to understand your question.
If it is about adding an icon button to allow the user to choose an image then yes,I think it should go in the input field besides the send icon.
But we also want to support drag and drop and copy paste...

@yaten2302
Copy link
Contributor

@FredLL-Avaiga , yes, I was asking about this only. I got it now 👍 I'll add an icon in the txt bar for adding images.
First, I'll create a draft PR for this and then if it looks good, then I'll also add support for drag and drop and copy paste.

@yaten2302
Copy link
Contributor

@FredLL-Avaiga , I've a doubt, that when I'm running this command - py -m pip install taipy-location, it's showing this error:

ERROR: Could not install packages due to an OSError: [WinError 2] The system cannot find the file specified: 'C:\\Python312\\Scripts\\cftp.exe' -> 'C:\\Python312\\Scripts\\cftp.exe.deleteme

I tried searching about it on stackoverflow, found this solution but, still it's not wokring :/ - py -m pip install --user taipy-location.
Actually, my application is still using taipy main lib even if I've changed certain things in the taipy elements(locally).

Any suggestions regarding how can I fix this?

@FredLL-Avaiga
Copy link
Member

What is taipy-location ?

@yaten2302
Copy link
Contributor

@FredLL-Avaiga ,the taipy location is: d:/taipy and the taipy-prac(in which the main.py file is present) is also in the d:/

@yaten2302
Copy link
Contributor

@FredLL-Avaiga , I was trying to install my local taipy package in a sample project, but when I'm click on the the location of import taipy.gui.builder as tgb, it's showing this:

image

But, since, my taipy file is located in d:/taipy, shouldn't it show this location? I tried to uninstall taipy as well and then run thes commands - py -m pip install taipy-location and py -m pip install --user taipy-location, since the 1st one was showing this error:

ERROR: Could not install packages due to an OSError: [WinError 2] The system cannot find the file specified: 'C:\\Python312\\Scripts\\cftp.exe' -> 'C:\\Python312\\Scripts\\cftp.exe.deleteme

@Satoshi-Sh
Copy link
Contributor

If you don't mind, can I start working on this issue?

@yaten2302
Copy link
Contributor

@Satoshi-Sh , thanks for the offer, but could you give me some time, currently working on to fix it :)

@Satoshi-Sh
Copy link
Contributor

Hi @yaten2302 , I think several people can work on the same issue. I will wait for a response from the maintainers.

@FlorianJacta
Copy link
Member

Yes, multiple people can work on the same issue and you can also collaborate together on it

@Satoshi-Sh
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Oct 22, 2024

@Satoshi-Sh has embarked on their Quest. 🗡

  • @Satoshi-Sh has been on GitHub since 2020.
  • They have merged 138 public PRs in that time.
  • Their swords are blessed with Python and HTML magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Copy link

quest-bot bot commented Oct 22, 2024

🧚 @Satoshi-Sh has submitted PR #2078 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 6, 2024
Copy link
Contributor

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 21, 2024
@Satoshi-Sh
Copy link
Contributor

Could this be closed? Implemented on #2078

@FredLL-Avaiga
Copy link
Member

PR #2078

FredLL-Avaiga pushed a commit that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI hacktoberfest - 300💎💎💎 Issues rewarded by 300 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants