Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG] [UX] input, number, date controls don't validate on focus out event #2023

Open
1 of 4 tasks
FabienLelaquais opened this issue Oct 11, 2024 · 17 comments · May be fixed by #2036
Open
1 of 4 tasks

[🐛 BUG] [UX] input, number, date controls don't validate on focus out event #2023

FabienLelaquais opened this issue Oct 11, 2024 · 17 comments · May be fixed by #2036
Assignees
Labels
🖰 GUI Related to GUI hacktoberfest - 100💎 Issues rewarded by 100 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 🥶Waiting for contributor Issues or PRs waiting for a long time

Comments

@FabienLelaquais
Copy link
Member

FabienLelaquais commented Oct 11, 2024

What went wrong? 🤔

The input control (as well as number, data, ...) does not trap the Focus Out event that should trigger the equivalent of pressing the Enter key

Expected Behavior

See description.

All input, number, date should be impacted.
login probably...

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Create related issue in taipy-doc for documentation and Release Notes.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@FabienLelaquais FabienLelaquais added 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 🖰 GUI Related to GUI labels Oct 11, 2024
@jrobinAV jrobinAV added 🆘 Help wanted Open to participation from the community hacktoberfest hacktoberfest issues hacktoberfest - 100💎 Issues rewarded by 100 points labels Oct 11, 2024
@AlexandreSajus AlexandreSajus removed 🆘 Help wanted Open to participation from the community hacktoberfest - 100💎 Issues rewarded by 100 points labels Oct 11, 2024
@jrobinAV jrobinAV added hacktoberfest - 100💎 Issues rewarded by 100 points 🆘 Help wanted Open to participation from the community labels Oct 11, 2024
@kart2004
Copy link

Hi @FabienLelaquais, I'd love to work on this issue. Could you please assign it to me?

@FlorianJacta
Copy link
Member

I have assigned you this issue @kart2004 !

@Anudhyan
Copy link

Hi @FabienLelaquais, I'd love to work on this issue. Could you please assign it to me?

could you please tell how are you working on this issue

@FabienLelaquais
Copy link
Member Author

I guess all you have to do is add an event handler to the 'onBlur' attribute of the TextField component used by the input control.
That would be in frontend/taipy-gui/src/components/Taipy/Input.tsx.
This should act just like 'onChange'.

@TecHAyusH6476
Copy link

@AlexandreSajus @FabienLelaquais Hey please assign the issue to me

@FabienLelaquais
Copy link
Member Author

This issue has been assigned already, @TecHAyusH6476 & @Anudhyan. Sorry

@Anudhyan
Copy link

This issue has been assigned already, @TecHAyusH6476 & @Anudhyan. Sorry

It's ok . I just wanted to know how to approach this issue, which you already clarified. Thanks

@kart2004 kart2004 linked a pull request Oct 12, 2024 that will close this issue
kart2004 added a commit to kart2004/taipy that referenced this issue Oct 12, 2024
@Faizalimam990
Copy link

What went wrong? 🤔

The input control (as well as number, data, ...) does not trap the Focus Out event that should trigger the equivalent of pressing the Enter key

Expected Behavior

See description.

All input, number, date should be impacted. login probably...

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Create related issue in taipy-doc for documentation and Release Notes.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)

@Faizalimam990
Copy link

Assing me this issue

@jrobinAV jrobinAV changed the title [🐛 BUG] [UX] input control does not validate on focus out event [🐛 BUG] [UX] input, number, date controls don't validate on focus out event Oct 15, 2024
@Heisen47
Copy link

Is this issue worked on ?

@FlorianJacta
Copy link
Member

I can assign this issue but this is already worked on by other contributors @Heisen47

@Anudhyan
Copy link

I can assign this issue but this is already worked on by other contributors @Heisen47

I am a newbie but I am still trying my best

FredLL-Avaiga added a commit to kart2004/taipy that referenced this issue Oct 22, 2024
@developervick
Copy link

Please try to assign this issue to me if possible.

@FlorianJacta
Copy link
Member

@developervick A PR is open, do you want to collaborate on this issue?

@hustler0109
Copy link

To address the issue of input fields not triggering actions on focusout, I propose adding an event listener to detect the focusout event for all relevant inputs (e.g., number, date fields). This listener would trigger the same function as pressing Enter, ensuring the expected action occurs when focus is lost. I'll ensure thorough unit tests for these handlers, aiming for 90% coverage. This approach should improve user experience across input fields. Would love to hear your feedback!

I am willing to work on this issue @jrobinAV

@jrobinAV
Copy link
Member

@hustler0109,
Thank you for your help.
You can propose your PR to solve the issue.
You can also collaborate with the other assignees having a look at their PRs and help us reviewing them.

FredLL-Avaiga added a commit to kart2004/taipy that referenced this issue Nov 2, 2024
FredLL-Avaiga added a commit to kart2004/taipy that referenced this issue Nov 7, 2024
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI hacktoberfest - 100💎 Issues rewarded by 100 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 🥶Waiting for contributor Issues or PRs waiting for a long time
Projects
None yet