Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_stat effect improperly calculated for per-piece armor effects #26

Open
Opalinium opened this issue Jun 10, 2022 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Opalinium
Copy link

Describe the bug
add_stat is improperly counted for pie-piece armor effects, seemingly based on stat values after bonuses, meaning the order in which armor is put on will completely change the final value

To Reproduce
Steps to reproduce the behavior:

  1. Create an armor set with add_stat (defense) as per-piece effects
  2. Equip the armor set in varying order
  3. Note the differences of stats applied based on the order you equip the individual armor pieces

Expected behavior
The add_stat effect should be additive comparatively to the base stat values, and should take into account multiple armor pieces in the event that per-piece effects are used

Screenshots
NVIDIA_Share_v250tQYHoN

Server Information (please complete the following information):

  • Version: Purpur-1566 1.18.1
  • Version of plugin: 7.74.0
  • Version of Eco: 6.36.4
@Opalinium Opalinium added the bug Something isn't working label Jun 10, 2022
@jezry
Copy link

jezry commented Jun 20, 2022

yes pls fix this

@OmegaWulf
Copy link

Same problem with bonus_health

The order of putting on the armor changes the amount granted. For me, adding the chestplate on last gives 20 more HP than it's supposed to.

Full set is supposed to give +100 hp but if the chestplate is put on last, the player gains +120.

For info: I'm only using individual armor bonuses and have no set bonus for HP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants