Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Navigation Stack Post-Processing Node #8

Open
2 tasks
zghera opened this issue Jan 22, 2022 · 1 comment
Open
2 tasks

Navigation Stack Post-Processing Node #8

zghera opened this issue Jan 22, 2022 · 1 comment
Labels
draft This needs to be fleshed out with more detail. enhancement New feature or request help wanted Extra attention is needed serial Related to the serial communication package of the ASS.

Comments

@zghera
Copy link
Member

zghera commented Jan 22, 2022

Description

Once #7 is complete, create a post-processing node that subscribes cmd_velocity as well as other topics from goal setting node (e.g. ebrake topic) and then publishes the topic with final info needed by the serial communication node (ti_comm_node as of now).

Currently, all of the processing in addition to the serial interfacing is done in the serial comm. node. This fix will increase modularity/extensibility (if serial packets need new information, just add a new topic that it subscribes to with exactly the info it needs - no processing) and increase the clarity of the software system as a whole by following the single responsibility principle.

Current architecture idea (excluding extra topics such as an ebrake topic):

View on draw.io here.

Sub-tasks

Other Useful Information

  • ...
@alanssitis alanssitis added the ASS label Jan 22, 2022
@zghera zghera added enhancement New feature or request serial Related to the serial communication package of the ASS. help wanted Extra attention is needed labels Jan 23, 2022
@zghera
Copy link
Member Author

zghera commented Jan 29, 2022

@ihagedo what do you think of the suggested system diagram above? Any suggestions?

Once you approve, we should break this down into sub-tasks. For that, we should probably talk live or at least over the phone. Ping me in Slack with times when you are available to discuss this.

@zghera zghera transferred this issue from Autonomous-Motorsports-Purdue/AMP_ASSv1 Feb 10, 2022
@ihagedo ihagedo mentioned this issue Feb 10, 2022
4 tasks
@zghera zghera added draft This needs to be fleshed out with more detail. and removed ASS labels Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
draft This needs to be fleshed out with more detail. enhancement New feature or request help wanted Extra attention is needed serial Related to the serial communication package of the ASS.
Projects
None yet
Development

No branches or pull requests

3 participants