Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cutoff when Adding Menu on Navigation block with "always" Overlay Menu #65526

Closed
1 task
edwinho89 opened this issue Jul 13, 2022 · 5 comments
Closed
1 task

Cutoff when Adding Menu on Navigation block with "always" Overlay Menu #65526

edwinho89 opened this issue Jul 13, 2022 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@edwinho89
Copy link

Quick summary

With "Always" setting on overlay menu under navigation block, the popup to insert link is hidden or cutoff to the left.

  • 5369973-zd-woothemes

Steps to reproduce

  1. On Site Editor or Page, add a navigation block
  2. Set "Overlay menu" on navigation block as "always"
  3. Click on the hamburger icon on navigation block to view menu
  4. Click 'plus' icon to insert new menu item

What you expected to happen

Behaviour would be similar when adding a new menu item without overlay menu option

What actually happened

Result:

image

With list view expanded:

image

Context

Also a separate issue: Expanding list view on page covers the overlay menu items on navigation

image

Gif: https://d.pr/i/vO4bpe

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

No response

Available workarounds?

Yes, easy to implement

Workaround details

Switch overlay setting on navigation block to "mobile" or "off".
@edwinho89 edwinho89 added [Type] Bug User Report This issue was created following a WordPress customer report labels Jul 13, 2022
@github-actions github-actions bot added the [Pri] Low Address when resources are available. label Jul 13, 2022
@Robertght
Copy link

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - Yes

📌 SCRUBBING

  • Tested on P2 ✅
  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I noticed a general inconsistency with this and other blocks as well. Seems to be an issue with other blocks as well but it's edge cases.

@annezazu do you know if this would fall into any ongoing PRs?

📌 ACTIONS

  • On-hold for now

📌 Message to Author

  • For the other issue could you open another report @edwinho89 ?

@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

  • 5369973-zen

@Robertght Robertght added the Triaged To be used when issues have been triaged. label Jul 18, 2022
@edwinho89 edwinho89 mentioned this issue Jul 18, 2022
Closed
@edwinho89
Copy link
Author

  • For the other issue could you open another report @edwinho89 ?

Created #65667 !

@annezazu
Copy link

@annezazu do you know if this would fall into any ongoing PRs?

@Robertght thanks for tagging me in 🤠 I think this most closely overlaps (get it) with this issue: WordPress/gutenberg#40382 and this work in progress PR: WordPress/gutenberg#40625

@Robertght Robertght added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Jul 21, 2022
@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Sep 13, 2024 •
edited
Loading

Fixed in core!!

Image

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrfoxtalbot @Robertght @annezazu @edwinho89