You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
select "Create Header", choose a pattern and create.
press the "undo" button, notice nothing is undone.
An undo trap has been created, preventing the user from being able to use 'undo' to undo the template part creation action or any actions prior to it.
Important notes:
This does not happen if you select "start blank" instead of a starting pattern.
This does not happen in core Gutenberg.
After syncing the most recent Gutenberg trunk as of this morning to dotcom sandbox, the issue persists.
This did not happen on dotcom a few weeks back, when e2e tests were written for the template part tracking flows.
On trying to 'undo' it seems to trigger replaceInnerBlocks and editEntityRecord for the template part.
Update:
This only seems to happen when the pattern selected contains the navigation-link component. Try creating a Footer using a pattern without a navigation component and 'undo' should work as expected.
Can now reproduce on core if using a pattern containing navigation-links like so:
Addison-Stavlo
changed the title
Site Editor - Undo Trap from template part creation with block patterns.
Site Editor - Undo Trap from navigation-links in block patterns.
Aug 5, 2021
Steps to reproduce the behavior
An undo trap has been created, preventing the user from being able to use 'undo' to undo the template part creation action or any actions prior to it.
Important notes:trunk
as of this morning to dotcom sandbox, the issue persists.On trying to 'undo' it seems to triggerreplaceInnerBlocks
andeditEntityRecord
for the template part.Update:
This only seems to happen when the pattern selected contains the
navigation-link
component. Try creating a Footer using a pattern without a navigation component and 'undo' should work as expected.Can now reproduce on core if using a pattern containing
navigation-link
s like so:Removing the navigation-link's from the pattern causes the undo to work as expected.
What I expected to happen
Undo to actually undo back to the placeholder:
What actually happened
undo does not work as expected as it is caught in an undo trap with the navigation-link components.
The text was updated successfully, but these errors were encountered: