Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payouts: Add a spotlight notice to announce rename from 'deposit' to 'payout' #9673

Closed
nagpai opened this issue Nov 5, 2024 · 10 comments · Fixed by #9680
Closed

Payouts: Add a spotlight notice to announce rename from 'deposit' to 'payout' #9673

nagpai opened this issue Nov 5, 2024 · 10 comments · Fixed by #9680
Assignees
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: payouts needs design The issue requires design input/work from a designer.

Comments

@nagpai
Copy link
Contributor

nagpai commented Nov 5, 2024

Add a dismissible spotlight notice to highlight the rename of 'deposit' to 'payout' for merchants.

@rogermattic shared a mockup of this:

There is a sweet component in WooCommerce core we can use

Reference

  • paJDYF-e8c-p2#comment-26855
@nagpai nagpai added category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: payouts needs design The issue requires design input/work from a designer. labels Nov 5, 2024
@jessy-p jessy-p self-assigned this Nov 5, 2024
@aheckler
Copy link
Member

aheckler commented Nov 5, 2024

Dropped some feedback on the copy in Slack: p1730802947821119/1729049775.777369-slack-C02BW3Z8SHK

@rogermattic
Copy link

Thanks @nagpai for creating the issue, I'll update the screenshot with an updated copy and the updated illustration asap.

I also wondered if this component could be reused as mentioned here: p1730803519217269-slack-C074153PC (is this a correct way to point out to stuff in Slack?). Apparently team Ghidorah developed the spotlight as a part of some previous work and it would be good to link to the component directly, if that's OK @adrianduffell ?

@rogermattic
Copy link

@adrianduffell kindly shared that it is a reusable component in the WooCommerce packages here! So I hope it will save us some work @nagpai ?

@jessy-p
Copy link
Contributor

jessy-p commented Nov 5, 2024

Just to confirm, this will be shown once for the merchant, and once dismissed, will not be shown again ?

@rogermattic
Copy link

rogermattic commented Nov 5, 2024

Hey @jessy-p ! That's right!

Also, just a note here, I'll finalise the copy of the spotlight and the illustration till the end of this week – will that give you enough time to swap the contents by the release, please?

@jessy-p
Copy link
Contributor

jessy-p commented Nov 6, 2024

I'll finalise the copy of the spotlight and the illustration till the end of this week – will that give you enough time to swap the contents by the release, please?

👋 @rogermattic Created a draft PR here though there is some pending work including tests, final copy and review etc. Our code freeze is this Friday, and we also have some AFK and additional hats on the team so it might be a challenge. Talked to @haszari and it is fine to target 8.6, if we cannot make it in 8.5

@rogermattic
Copy link

👋 @rogermattic Created a draft PR #9680 though there is some pending work including tests, final copy and review etc. Our code freeze is this Friday, and we also have some AFK and additional hats on the team so it might be a challenge. Talked to @haszari and it is fine to target 8.6, if we cannot make it in 8.5

Thanks a lot – I've requested an illustration and a copy review and will confirm tomorrow what's the progress on that!

@brucealdridge brucealdridge linked a pull request Nov 7, 2024 that will close this issue
6 tasks
@shendy-a8c shendy-a8c added this to the WooPayments 8.5.0 milestone Nov 7, 2024
@shendy-a8c
Copy link
Contributor

@rogermattic just to confirm when this spotlight ui should popup. It should popup when user goes to the deposits list page, right?
How about deposit details page? When user open the deposit details page, the 'Payouts' menu will be highlighted just like when they open the deposits list page, so maybe make sense to open the spotlight UI there too?

@rogermattic
Copy link

just to confirm when this spotlight ui should popup. It should popup when user goes to the deposits list page, right?

Good question! I was thinking that it could popup when the user opens the dashboard in general for the first time after the name swap is released, WDYT? Otherwise if they somehow directly go to the Deposits list / Deposit page or a payment overview..

@rogermattic
Copy link

Update on assets:

We have a revised copy now:

Deposits are now known as Payouts!
Same reliable system for giving you access to your earnings quickly — a new, clearer name. In our quest to provide you with the best possible experience, we're making some changes to our terminology. "Deposits" will now be known as "Payouts"

And the illustration in Figma:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: payouts needs design The issue requires design input/work from a designer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants