Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments → Overview link/highlight colours are inconsistent for users with a custom admin theme enabled #9584

Open
Jinksi opened this issue Oct 18, 2024 · 2 comments · May be fixed by #9641
Assignees
Labels
focus: payouts focus: reporting priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@Jinksi
Copy link
Member

Jinksi commented Oct 18, 2024

Describe the bug

For users who have a custom WP admin theme enabled, links and highlights on the Payments → Overview screen are inconsistent, with some elements using the theme highlight colour and others using a hard-coded blue colour.

It is common for users to have a custom admin theme enabled, as some WordPress themes introduce additional admin themes that may be selected by default for users.

For example, WPCOM-hosted sites have custom admin themes available, including "Classic Dark" which was the default WooExpress theme, with magenta highlights.

Screenshots

Image

Image

To Reproduce

  1. In WP Admin, navigate to Users → Profile
  2. Select a different admin theme
    Image
  3. Navigate to Payments → Overview
  4. Notice that some links are coloured blue, while some match the admin theme colours.

Expected behavior

Links and highlights should use custom theme colours.

Additional context

Discussed in PR #9571

@Jinksi
Copy link
Member Author

Jinksi commented Oct 18, 2024

Assigning this with focus: deposits and focus: reporting since most/all of the problematic links are within related cards on the overview screen.

@haszari haszari added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Oct 20, 2024
@Jinksi Jinksi self-assigned this Oct 28, 2024
@Jinksi Jinksi added this to the WooPayments 8.5.0 milestone Oct 29, 2024
@haszari
Copy link
Contributor

haszari commented Nov 11, 2024

Shifting this back to In progress while we're waiting on input from design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: payouts focus: reporting priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
2 participants