Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Terminology: Action Used Instead of Filter #9335

Open
alexmigf opened this issue Aug 26, 2024 · 0 comments · May be fixed by #9340
Open

Incorrect Terminology: Action Used Instead of Filter #9335

alexmigf opened this issue Aug 26, 2024 · 0 comments · May be fixed by #9340
Labels
focus: multi-currency

Comments

@alexmigf
Copy link

woocommerce-payments/includes/multi-currency/FrontendCurrencies.php

Line 119 in ad1395d

add_action( 'woocommerce_get_formatted_order_total', [ $this, 'maybe_clear_order_currency_after_formatted_order_total' ], 900, 4 );

While this does work, it refers to an action when it should actually be a filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: multi-currency
Projects
None yet
Milestone
No milestone
2 participants
@alexmigf @c-shultz