Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow was succeeding even though phpcs has reported errors. #384

Closed
mi5t4n opened this issue Feb 22, 2024 · 1 comment · May be fixed by #385
Closed

Workflow was succeeding even though phpcs has reported errors. #384

mi5t4n opened this issue Feb 22, 2024 · 1 comment · May be fixed by #385

Comments

@mi5t4n
Copy link

mi5t4n commented Feb 22, 2024

Bug report

The workflow was succeeding even though there were phpcs errors present. Comments where also not being added to the PR as well.

Expected behavior

The workflow should fail if there any phpcs errors. Comments should be added to the PR.
@mi5t4n mi5t4n changed the title workflow was succeeding even though phpcs has reported problems. workflow was succeeding even though phpcs has reported errors. Feb 22, 2024
@mi5t4n mi5t4n changed the title workflow was succeeding even though phpcs has reported errors. Workflow was succeeding even though phpcs has reported errors. Feb 22, 2024
@mi5t4n mi5t4n mentioned this issue Feb 22, 2024
Open
11 tasks
@gudmdharalds
Copy link
Contributor

gudmdharalds commented May 20, 2024 •
edited
Loading

See #385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: phpcs error parse issue by running phpcs in quiet mode mi5t4n/vip-go-ci
2 participants
@mi5t4n @gudmdharalds