[DotCom Launch]: Grammer

[iamtakashi]

DotCom launch checklist

• Theme review
• Create demo site
• Create theme showcase
• Network activate
• Add theme to the curated list
• Verify theme in showcase
• Verify theme in onboarding

[iamtakashi]

@henriqueiamarino, here are my notes!

• The 50% width search in the archives and the search results templates is awkward on small screens. It would be good if it were done like the one in the 404 template or if a columns block were used to utilise the whole screen width when the viewport is small.
  
  

• I find the simple header with image template part a little strange. I think the image belongs more naturally to the pages template rather than the header template part. Also, did you want to show the page's title on the cover? If so, use the title block.

• There is no text decoration on links in the light mode.

• While you're looking at the variation, make sure if all the styles in the theme.json for the light mode. There seem to be duplicated styles that are the same as the default.

• The custom spacing sizes 60, 70, and 80 aren't used in the theme. Consider if you want to keep them in the theme.

• Let's make the label the same as the max value for the custom font sizes.

• Remove both images bundled.

• There is a text string that needs to be internationalised in the parts/post-meta.html: "Topics". So, it needs to be converted to a pattern. Re-saving the theme should fix it.

• Remove the patterns/home.php, patterns/index.php, and patterns/simple-header-with-image.php.

• Let's list all the template parts with titles in the theme.json

• There are text strings that need to be internationalised in the templates/404.html, templates/archive.html, and templates/search.html. So, they need to be converted to a pattern. Re-saving the theme should fix it.

• A main tag is missing in the template/home.html, template/index.html, template/page.html, and template/single.html.

• Add 6.7 to Tested up to: in the readme.txt and style.css.

• Add 7.2 to Requires PHP: in the readme.txt and style.css.

• Add a credit for Albert Sans to the readme.txt.

• Remove the duplicated comments in the style.css

/*
 * Font smoothing
 * https://github.com/WordPress/gutenberg/issues/35934
 */

• Remove the following theme tags: block-patterns, full-width-template, template-editing, and theme-options.
• There is a text size of 1.1 rem in the 404 template, let's use the medium size since it's close.

[henriqueiamarino]

Thanks, @iamtakashi. My fixes are here #8627.