From 9965cad934baf01b9f04dc0abdee88075fc1c244 Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Sun, 3 Nov 2024 08:08:42 +1100 Subject: [PATCH 1/3] Fix label name for upload metadata step --- .../release-pipelines/update-metadata-on-app-store-connect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml b/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml index 94273bce7..e4932a29f 100644 --- a/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml +++ b/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml @@ -10,7 +10,7 @@ env: IMAGE_ID: $IMAGE_ID steps: - - label: Finalize Release + - label: Update Release Notes and Other Metadata on App Store Connect plugins: [$CI_TOOLKIT_PLUGIN] command: | echo '--- :robot_face: Use bot for Git operations' From 17ff370b9ca53202d29282a81225b19d10f8eeee Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Sun, 3 Nov 2024 08:09:43 +1100 Subject: [PATCH 2/3] Remove `skip_confirm` parameter from update metadata lane call --- .../release-pipelines/update-metadata-on-app-store-connect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml b/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml index e4932a29f..356f1e68c 100644 --- a/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml +++ b/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml @@ -25,7 +25,7 @@ steps: bundle exec fastlane run configure_apply echo '--- :shipit: Update Release Notes and Other App Store Metadata' - bundle exec fastlane update_metadata_on_app_store_connect skip_confirm:true + bundle exec fastlane update_metadata_on_app_store_connect retry: manual: # If those jobs fail, one should always prefer re-triggering a new build from ReleaseV2 rather than retrying the individual job from Buildkite From ee530cdd46824c6e437c0ad020677726eea8662a Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Sun, 3 Nov 2024 08:15:07 +1100 Subject: [PATCH 3/3] Restore `skip_confirm` parameter for ASC metadata and wire with `force` --- .../update-metadata-on-app-store-connect.yml | 2 +- fastlane/Fastfile | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml b/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml index 356f1e68c..e4932a29f 100644 --- a/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml +++ b/.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml @@ -25,7 +25,7 @@ steps: bundle exec fastlane run configure_apply echo '--- :shipit: Update Release Notes and Other App Store Metadata' - bundle exec fastlane update_metadata_on_app_store_connect + bundle exec fastlane update_metadata_on_app_store_connect skip_confirm:true retry: manual: # If those jobs fail, one should always prefer re-triggering a new build from ReleaseV2 rather than retrying the individual job from Buildkite diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 8eb852599..17c99730b 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -84,7 +84,7 @@ platform :ios do # @option [Boolean] with_screenshots (default: false) If true, will also upload the latest screenshot files to ASC # desc 'Upload the localized metadata to App Store Connect, optionally including screenshots.' - lane :update_metadata_on_app_store_connect do |with_screenshots: false| + lane :update_metadata_on_app_store_connect do |skip_confirm: false, with_screenshots: false| # Skip screenshots by default. The naming is "with" to make it clear that # callers need to opt-in to adding screenshots. The naming of the deliver # (upload_to_app_store) parameter, on the other hand, uses the skip verb. @@ -99,7 +99,8 @@ platform :ios do overwrite_screenshots: true, # won't have effect if `skip_screenshots` is true phased_release: true, precheck_include_in_app_purchases: false, - api_key_path: APP_STORE_CONNECT_KEY_PATH + api_key_path: APP_STORE_CONNECT_KEY_PATH, + force: skip_confirm ) end