Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix widget note or note list leakage when pin lock is enabled #1636

Closed
wants to merge 6 commits into from
Closed

Fix widget note or note list leakage when pin lock is enabled #1636

wants to merge 6 commits into from

Conversation

jimlearning
Copy link

Fix

It's possible to see all your notes from widgets even though pin lock(password) is active.

  1. Turn on pin lock.
  2. When choose note widget or note list in widgets center, the snapshot of note or note list is shown without protected.
  3. When display a note widget or note list widget, the note or note list is shown without protected.
  4. When edit a note widget, all note list can be seen, and any note can be selected then displayed in the note widget.

In this PR I have added pinLockIsEnabled state to check all notes or note list in widgets, just like the way when logged out. When pinLockIsEnabled is true, the note or note list is hidden, otherwise it is displayed.

fixes #1445

Test

  1. Turn on pin lock.
  2. When choose note widget or note list in widgets center, the snapshot of note or note list will be shown as "Unlock to see your note/note list".
  3. When a note widget or note list widget added, the note or note list will be shown as "Unlock to see your note/note list".
  4. When edit a note widget, the note list will not be shown and selected.
  5. Turn off pin lock, the note widget or note list widget will be shown normally.

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

@jleandroperez
Copy link
Contributor

Hey there @jimlearning,

Thank you for your contribution! I'm afraid this feature would break current workflows, for people who use pinlock code, and keep groceries in their springboards (such as myself!).

@jimlearning
Copy link
Author

jimlearning commented Aug 29, 2024 •
edited
Loading

Hey there @jimlearning,

Thank you for your contribution! I'm afraid this feature would break current workflows, for people who use pinlock code, and keep groceries in their springboards (such as myself!).

Thank you for your reply. I've added a switch that lets the user decide if the widgets should be locked as well. Not locked by default.

@jleandroperez
Copy link
Contributor

@jimlearning Thank you so much for your contribution and for taking the time to propose this feature!

The team has carefully reviewed the PR, and while we really appreciate the thought and effort you put into it, we’ve decided not to merge it at this time.

@jleandroperez
Copy link
Contributor

jleandroperez commented Sep 16, 2024 •
edited
Loading

Adding a bit of context:

We believe that this concrete issue should be addressed via a change in the way the Notes Widget works.

Everytime a new Note is selected, whenever the app has a pincode set, the Widget itself should display a 'Locked' placeholder, directing the user to launch the app, to Unlock Access to such note.

This is a much simpler approach, doesn't involve 'Setting discoverability' issues, and would preserve current flows.

@jimlearning
Copy link
Author

Adding a bit of context:

We believe that this concrete issue should be addressed via a change in the way the Notes Widget works.

Everytime a new Note is selected, whenever the app has a pincode set, the Widget itself should display a 'Locked' placeholder, directing the user to launch the app, to Unlock Access to such note.

This is a much simpler approach, doesn't involve 'Setting discoverability' issues, and would preserve current flows.

Thanks. I'm glad to hear the team is considering this issue, and can't wait to see the new feature rolled out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Widgets] Possible to see any note content with passcode active
2 participants
@jimlearning @jleandroperez