Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename text domain #44

Closed
benlk opened this issue Sep 5, 2018 · 1 comment
Closed

rename text domain #44

benlk opened this issue Sep 5, 2018 · 1 comment
Assignees
@benlk
Milestone
1.3.2.1: Gutenber...

Comments

@benlk
Copy link
Collaborator

benlk commented Sep 5, 2018

When did I introduce the text domain? Can we rename it from pym-shortcode to pym-embeds without affecting stuff?

I mean, this plugin doesn't ship with translation files at the moment, so how hard could it be?
@benlk benlk added this to the 1.3.2.1: Gutenberg Support milestone Sep 5, 2018
@benlk benlk self-assigned this Sep 5, 2018
@benlk
Copy link
Collaborator Author

benlk commented Sep 6, 2018

Text domain was added in #34, so it's new in 1.3.2.1 and we can change it before 1.3.2.1 is released.

benlk added a commit that referenced this issue Sep 6, 2018
@benlk
rename plugin text domain from pym-shortcode to pym-embeds, for #44
c10a142
benlk added a commit that referenced this issue Sep 6, 2018
@benlk
Merge pull request #46 from INN/44-rename-text-domain
a866614 
rename plugin text domain from pym-shortcode to pym-embeds, for #44
@benlk benlk closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
None yet
Projects
None yet
Milestone
1.3.2.1: Gutenberg Support
Development

No branches or pull requests
1 participant
@benlk