Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error result when css comment contains < #216

Closed
akuma opened this issue Jun 23, 2016 · 1 comment
Closed

Error result when css comment contains < #216

akuma opened this issue Jun 23, 2016 · 1 comment

Comments

@akuma
Copy link

akuma commented Jun 23, 2016

The example html content:

<style>
/* somebody <[email protected]> */
.content {
  background: #002b36;
  color: #839496;
}
</style>
<div class="content">Hello!</div>

The error result is:

<style>
/* somebody <[email protected]> */
.content {
  background: #002b36;
  color: #839496;
}
</somebody@gmail.com></style>
<div class="content">Hello!</div>

The result should be:

<div class="content" style="background: #002b36; color: #839496;">Hello!</div>
@akuma akuma changed the title Error result when parsing html which contains '<' in css comments Error result when parsing html which contains < in css comments Jun 23, 2016
@akuma akuma changed the title Error result when parsing html which contains < in css comments Error result when css comment contains < Jun 23, 2016
bago added a commit to bago/juice that referenced this issue Jun 23, 2016
Test case for Automattic#216
This is fixed by moving from cssom to mensch as per Automattic#215
@bago
Copy link
Contributor

bago commented Jun 23, 2016

I've replaced cssom with mensch in a development branch (see #215 and https://github.com/bago/juice/tree/menschified) and this issue is fixed (output equals the expected result).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants