Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SiteEditorSnackbars #38442

Closed
richtabor opened this issue Jul 20, 2024 · 3 comments · Fixed by #38459
Closed

Remove SiteEditorSnackbars #38442

richtabor opened this issue Jul 20, 2024 · 3 comments · Fixed by #38459
Assignees
Labels
[Extension] Site Editor Snackbars [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] TBD [Type] Bug When a feature is broken and / or not performing as intended

Comments

@richtabor
Copy link

richtabor commented Jul 20, 2024

It's confusing that these come from Jetpack, and also these snackbars do not offer any additional benefit from what core does in the editor header( defining what template is currently being edited, when you're editing a template).

It's just additional UI without any benefit (something WordPress as a whole needs to level-up on).

On top of that, the snackbar is inaccurate: rendering "Editing the Pages template" when editing a page's content in the Site Editor, and a few other inconsistencies that aid in making navigating the Site Editor more confusing (with Jetpack active).

I propose we remove these snackbars. One less thing to maintain, and a bit clearer experience for users.

Visual

CleanShot.2024-07-19.at.22.11.12.mp4

Code

@jeherve
Copy link
Member

jeherve commented Jul 22, 2024

cc @mmtr who added those in #28810. Is that snackbar still relevant today?

@jeherve jeherve added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 22, 2024
@mmtr
Copy link
Member

mmtr commented Jul 22, 2024

Is that snackbar still relevant today?

Probably not.

IIRC, they were only needed for the Link in Bio flow in WordPress.com because users trying to complete the "Add links" task from launchpad were not aware that they were actually editing a site template.

  • The task sent users to the site editor directly with the "edit" mode active (i.e. they didn't select any template to edit)
  • There was a "Customize your domain" nudge hiding the template title that appears at the top of editor.

With the snackbar, they had some context about what they were editing. The video below was recorded in Feb 2023:

Screen.Recording.2023-02-09.at.12.07.17.mov

Said that, it seems that the Link in Bio flow is quite differently today (July 2024):

  • We no longer send users to the site editor in "edit" mode. We load the default "view" mode instead which requires users to explicitly select a template to edit first.
  • The template title is no longer hidden by the "Customize your domain" nudge.
Screen.Recording.2024-07-22.at.14.14.33.mov

So I think it's fine if we remove these snackbars.

@richtabor
Copy link
Author

Thanks for jumping on this. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] Site Editor Snackbars [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] TBD [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

3 participants