-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SiteEditorSnackbars #38442
Comments
Probably not. IIRC, they were only needed for the Link in Bio flow in WordPress.com because users trying to complete the "Add links" task from launchpad were not aware that they were actually editing a site template.
With the snackbar, they had some context about what they were editing. The video below was recorded in Feb 2023: Screen.Recording.2023-02-09.at.12.07.17.movSaid that, it seems that the Link in Bio flow is quite differently today (July 2024):
Screen.Recording.2024-07-22.at.14.14.33.movSo I think it's fine if we remove these snackbars. |
Thanks for jumping on this. 🚀 |
It's confusing that these come from Jetpack, and also these snackbars do not offer any additional benefit from what core does in the editor header( defining what template is currently being edited, when you're editing a template).
It's just additional UI without any benefit (something WordPress as a whole needs to level-up on).
On top of that, the snackbar is inaccurate: rendering "Editing the Pages template" when editing a page's content in the Site Editor, and a few other inconsistencies that aid in making navigating the Site Editor more confusing (with Jetpack active).
I propose we remove these snackbars. One less thing to maintain, and a bit clearer experience for users.
Visual
CleanShot.2024-07-19.at.22.11.12.mp4
Code
jetpack/projects/plugins/jetpack/extensions/plugins/site-editor-snackbars/index.js
Line 5 in a87dd0c
The text was updated successfully, but these errors were encountered: