Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Boost] Prevent bad URLs from breaking Critical CSS Generator #44

Open
thingalon opened this issue Feb 9, 2024 · 1 comment
Open

[Boost] Prevent bad URLs from breaking Critical CSS Generator #44

thingalon opened this issue Feb 9, 2024 · 1 comment

Comments

@thingalon
Copy link
Member

thingalon commented Feb 9, 2024 •
edited
Loading

Related: Automattic/jetpack#35561

If a bad URL gets fed into one Critical CSS provider, the whole process fails with a meaningless error:

Failed to construct 'URL': Invalid URL

If parsing a URL fails, it should throw a provider-specific error message, and specify what URL was invalid.
@alinclamba
Copy link

When this fix will be released, would be nice to let the user know, so adding the Zendesk ticket here as a reminder: 7710563-zd-a8c

@thingalon thingalon self-assigned this Mar 14, 2024
@thingalon thingalon removed their assignment Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thingalon @alinclamba