Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection isn't passed with isTriggeredByYDoc #138

Open
johngodley opened this issue May 6, 2022 · 0 comments
Open

Selection isn't passed with isTriggeredByYDoc #138

johngodley opened this issue May 6, 2022 · 0 comments
Labels
bug Something isn't working [Feature] Collaboration Real-time collaborative editing

Comments

@johngodley
Copy link
Member

When a UPDATE_BLOCKS_WITH_UNDO is triggered and isTriggeredByYDoc is present the selection isn't passed. This has the effect of resetting the selection status in the editor undo history, and when you travel to the point the focus is removed from the editor.

To reproduce:

  • Start storybook 'with on load'
  • Click on the end of the first line, press enter, and type a letter (a)
  • Press undo
  • Press undo. Focus has now been lost

Looking at the store actions. The selection is passed here:

image

However it isn't here:

image

I'm not sure why the number of blocks would be so different either

@johngodley johngodley added bug Something isn't working [Feature] Collaboration Real-time collaborative editing labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [Feature] Collaboration Real-time collaborative editing
Projects
None yet
Development

No branches or pull requests

1 participant