You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
WordPress.WP.AlternativeFunctions.file_system_operations error messages are overwritten in the ruleset, e.g.
<rule ref="WordPress.WP.AlternativeFunctions.file_system_operations_fopen">
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/</message>
</rule>
However since WPCS 3.0.0 this error can only be fixed by using WP_Filesystem. Neither get_temp_dir() or wp_get_upload_dir() will make the error go away and it's unclear why (unless you debug and find the original error message where it says WP_Filesystem)
Bug Description
WordPress.WP.AlternativeFunctions.file_system_operations
error messages are overwritten in the ruleset, e.g.However since WPCS 3.0.0 this error can only be fixed by using
WP_Filesystem
. Neitherget_temp_dir()
orwp_get_upload_dir()
will make the error go away and it's unclear why (unless you debug and find the original error message where it saysWP_Filesystem
)Minimal Code Snippet
Error Code
WordPress.WP.AlternativeFunctions.file_system_operations_fopen
Environment
Additional Context (optional)
With
WP_Filesystem
, I think it's unnecessary to overwrite those errors in the first place and these overwrites can all be removed from ruleset.xmlPossibly, errors like
WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fputcsv
should be changed to a also only allowWP_Filesystem
?Tested Against
main
branch?main
branch of VIPCS.develop
branch of VIPCS.The text was updated successfully, but these errors were encountered: