Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickEditor: Downsize uploaded image #305

Closed
AdamGrzybkowski opened this issue Sep 10, 2024 · 5 comments · Fixed by #348
Closed

QuickEditor: Downsize uploaded image #305

AdamGrzybkowski opened this issue Sep 10, 2024 · 5 comments · Fixed by #348
Assignees
Labels
Bug Something isn't working Feature: gravatar-quickeditor Gravatar Quick Editor module
Milestone

Comments

@AdamGrzybkowski
Copy link
Contributor

There's a bug in UCrop that cause the cropped images to keep their original file size.

The PR with a fix is open but it seems unlikely we can get it merged.

@AdamGrzybkowski AdamGrzybkowski added Bug Something isn't working Feature: gravatar-quickeditor Gravatar Quick Editor module labels Sep 10, 2024
@AdamGrzybkowski AdamGrzybkowski added this to the 2.0.0 milestone Sep 10, 2024
@AdamGrzybkowski
Copy link
Contributor Author

@maxme It looks like we will have to go with the fork. Do you want to use the WP one, or create a new one?

@maxme
Copy link
Contributor

maxme commented Sep 10, 2024

Do you want to use the WP one, or create a new one?

The WP one is not used. WPAndroid uses the official version now (v2.2.9), the repo should be closed or deprecated.

IMO we should create a new one, forking the official repo under the automattic/ group. If we have to keep it, and eventually if WPAndroid also needs this fork, I think it's better if its under automattic. What do you think about it?

@AdamGrzybkowski
Copy link
Contributor Author

What do you think about it?

Sounds good.

@AdamGrzybkowski
Copy link
Contributor Author

@wzieba What would be the best way to have our fork version released?

@wzieba
Copy link
Member

wzieba commented Sep 11, 2024

I think our local own instance of S3 would be fine. At the same time, it'd be maybe nice to offer this on Maven Central, so the open source community can benefit from your fix from a trusted repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feature: gravatar-quickeditor Gravatar Quick Editor module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants