Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NavBar stick at top #34

Open
bsakai2000 opened this issue Nov 22, 2019 · 2 comments
Open

Make NavBar stick at top #34

bsakai2000 opened this issue Nov 22, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bsakai2000
Copy link
Member

navbar component should stick to stop of screen as user scrolls

@bsakai2000 bsakai2000 added the enhancement New feature or request label Nov 22, 2019
@JellyWang7
Copy link
Contributor

Now it should be fixed in frontend branch

@bsakai2000
Copy link
Member Author

Not sure this is fixed. Navbar is see through, which means it's unreadable when scrolled over other text.

We can put a different color background to distinguish it, but that creates a weird box (it doesn't extend to the top or sides)

diff --git a/src/app/navbar/navbar.component.css b/src/app/navbar/navbar.component.css
index 1dff455..80eb4eb 100644
--- a/src/app/navbar/navbar.component.css
+++ b/src/app/navbar/navbar.component.css
@@ -1,5 +1,6 @@
 .navbar{
     color:black;
+    background-color: lightgray;
 }
 .nav-item{
     color: black;

We could also keep it white but put some sort of delimiter between the navbar and content, but we have a similar issue with not reaching the sides

diff --git a/src/app/navbar/navbar.component.css b/src/app/navbar/navbar.component.css
index 1dff455..48cafb6 100644
--- a/src/app/navbar/navbar.component.css
+++ b/src/app/navbar/navbar.component.css
@@ -1,5 +1,8 @@
 .navbar{
     color:black;
+    background-color: white;
+    border-bottom-style: solid;
+    border-bottom-color: black;
 }
 .nav-item{
     color: black;

I'm not sure what the best way forward is

@bsakai2000 bsakai2000 reopened this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants