Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified regular expression #426

Closed
wants to merge 1 commit into from
Closed

Modified regular expression #426

wants to merge 1 commit into from

Conversation

igeni
Copy link

@igeni igeni commented Mar 23, 2024

Modified regular expression to add support of the unicode characters processing and make code simple

@igeni igeni requested a review from vjeeva as a code owner March 23, 2024 11:26
Copy link

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. We ask that you sign our Contributor License Agreement before we can accept your contribution.

If you are contributing on behalf of your employer you must fill out our Corporate Contributor License Agreement which can be found here.
If you are contributing on behalf of yourself you must agree to our Individual Contributor License Agreement by reviewing this document and signing it or by replying below a with a comment containing the following text:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@vjeeva
Copy link
Contributor

vjeeva commented Mar 25, 2024

Hi @igeni, thanks for your contribution! Two things I'd like to ask:

  1. Do you have specific examples where this regex change helps, to illustrate the issue?

  2. Would you please sign the CLA for this contribution to be allowed?

Our CI is running now to ensure things look good regardless :)

@vjeeva
Copy link
Contributor

vjeeva commented Apr 2, 2024

If no response is obtained by April 3, 2024, I will be closing this PR!

@vjeeva vjeeva closed this Apr 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants