Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Git Requests Report need to specifically exclude 401 errors #178

Open
mzzmjd opened this issue Mar 18, 2019 · 1 comment
Open

The Git Requests Report need to specifically exclude 401 errors #178

mzzmjd opened this issue Mar 18, 2019 · 1 comment
Assignees
Labels

Comments

@mzzmjd
Copy link

mzzmjd commented Mar 18, 2019

The Git usage reports do not exclude 401 errors for https requests. Therefore it can give a misleading number of git requests (doubled for https requests).

Git will never send a password over HTTP unless it receives a 401 status from the server explicitly asking for the password. What this means is that on the first attempt to connect to a remote repository over http(s) Git will send only the username but not the password. When Git Server intercepts this request and can't proceed because a username and password are required, it returns the HTTP status of 401 to Git. Git receives this response, and then re-sends the request using the username and password that were provided.

Example, would be https://github.com/Autodesk/hubble/blob/master/updater/scripts/git-requests.sh

@pluehne
Copy link
Contributor

pluehne commented Mar 21, 2019

@mzzmjd: Thanks for pointing this out. I’ll have a look at what we can do to fix this.

@pluehne pluehne self-assigned this Mar 21, 2019
@pluehne pluehne added the bug label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants