From 7f5e63154f0c79d2fda6bade8baf942f48292f5e Mon Sep 17 00:00:00 2001 From: Younes Strittmatter Date: Mon, 20 May 2024 02:22:07 +0000 Subject: [PATCH] fix if else logic number submissions > observations --- src/autora/experiment_runner/firebase_prolific/__init__.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/autora/experiment_runner/firebase_prolific/__init__.py b/src/autora/experiment_runner/firebase_prolific/__init__.py index d2d8ec5..5b6c2b8 100644 --- a/src/autora/experiment_runner/firebase_prolific/__init__.py +++ b/src/autora/experiment_runner/firebase_prolific/__init__.py @@ -13,7 +13,8 @@ publish_study, get_submissions_incompleted, request_return_all, - approve_all_no_code + approve_all_no_code, + approve_all ) @@ -96,6 +97,7 @@ def _firebase_prolific_run(conditions, **kwargs): # check prolific if prolific_dict: if not counter % 5: + approve_all(study_id, kwargs["prolific_token"]) if approve_no_code: approve_all_no_code(study_id, kwargs["prolific_token"]) else: @@ -109,7 +111,7 @@ def _firebase_prolific_run(conditions, **kwargs): check_prolific = check_prolific_status(study_id, kwargs["prolific_token"]) if ( check_prolific["number_of_submissions"] - >= check_prolific["total_available_places"] and check_firebase == "finished" + >= check_prolific["total_available_places"] ): if check_firebase == "finished": observation = get_observations("autora", kwargs["firebase_credentials"])