Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove model as property since it is implemented as alias #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove model as property since it is implemented as alias #92

wants to merge 3 commits into from

Conversation

younesStrittmatter
Copy link
Contributor

Description

remove model as property since it is implemented as alias

Type of change

  • fix: A bug fix

@younesStrittmatter younesStrittmatter self-assigned this Aug 10, 2024
@younesStrittmatter younesStrittmatter linked an issue Aug 10, 2024 that may be closed by this pull request
remove "model" as property #91
Open
musslick
musslick approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musslick musslick musslick approved these changes

@hollandjg hollandjg Awaiting requested review from hollandjg

Assignees

@younesStrittmatter younesStrittmatter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove "model" as property grid pooler and random pooler expect different arguments
2 participants
@younesStrittmatter @musslick