Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Admin rights when creating a new hub #90

Open
pegahcarter opened this issue Jul 17, 2024 · 1 comment
Open

Enforce Admin rights when creating a new hub #90

pegahcarter opened this issue Jul 17, 2024 · 1 comment

Comments

@pegahcarter
Copy link
Contributor

It should be double-checked on contract-side to verify whether we are correctly enforcing admin rights after deploying a new hub. This may need to be checked on ĀutID.sol side as well. Maybe adding a "label" such as "Admin" vs. "Participant" for each Hub struct in ĀutID.
@pegahcarter
Copy link
Contributor Author

Currently, HubRegistry.deployHub() is openly-callable (I've commented out Allowlist). IMO, there's no reason to guard creation of a hub- it creates additional admin overhead to create new hubs on behalf of users and restricts users from openly playing around with the protocol. Lmk your thoughts @Jabyl .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pegahcarter